fix: PendingRequest refactor regressions #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've noticed a couple of other regressions from the PendingRequest refactor, so I have expanded this PR to cover them also. |
ChrisB-TL
changed the title
sixlive
changed the title
sixlive
approved these changes
Jan 25, 2025
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression 1 - exception thrown if you use
toRequest()more than onceIf you run
toRequest()on aPendingRequestbefore generate()- e.g. to inspect the request before running it - you trigger apromptOrMessageexception as it populates the messages property on the first run.Fixed by manipulating a variable rather than the property.
Regression 2 - Text Generator not adding system prompt to first step
Previously, a system prompt would be included in the first step's messages array. This PR reinstates it.
Regression 3 - Structured Generator not adding system prompt or prompt to first step
Similar to above, but also applies to the user prompt.