Skip to content

Commit 4ed72e4

Browse files
committed
chore: apply change requests from review
1 parent 7d5bf64 commit 4ed72e4

File tree

5 files changed

+20
-27
lines changed

5 files changed

+20
-27
lines changed

specifications/catalog/catalog.protocol.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ abstract [=Message=] exchange format. The concrete [=Message=] exchange wire for
77

88
The [=Catalog Protocol=] reuses properties from the DCAT and ODRL vocabularies with restrictions defined in this
99
specification. This is done implicitly by the use of the JSON schemas and JSON-LD-contexts that are part of the [=Dataspace Protocol=].
10-
Servers _MUST NOT_ process properties that are not part of the schemas.
10+
Servers _MAY_ process properties that are not part of the schemas.
1111

1212
## Message Types
1313

@@ -94,7 +94,7 @@ An [=Offer=] contains the following attributes:
9494

9595
- An [=Offer=] _MUST_ be unique to a [=Dataset=] since the target of the [=Offer=] is derived from its enclosing context.
9696

97-
- [=Offers=] _MUST NOT_ contain any `target` attributes. The value of the `target` attribute _MUST_ be the [=Dataset=] identifier. (_NOTE: If the [=Offer=] is used in an enclosing [=Catalog=] or [=Dataset=], there must not be any `target` attribute set._)
97+
- [=Offers=] _MAY_ contain any `target` attributes. The value of the `target` attribute _MUST_ be the [=Dataset=] identifier. (_NOTE: If the [=Offer=] is used in an enclosing [=Catalog=] or [=Dataset=], there must not be any `target` attribute set._)
9898

9999
### ERROR - Catalog Error
100100

specifications/negotiation/contract.negotiation.binding.https.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ Authorization: ...</pre>
124124
**Response**
125125

126126
If the message is successfully processed, the [=Provider=] _MUST_ return an HTTP 200 (OK) response. The response body is
127-
not specified and clients _MUST NOT_ process it.
127+
not specified and clients _MAY_ process it.
128128

129129
### Contract Negotiation Event Endpoint {#negotiations-providerpid-events-post}
130130

@@ -168,7 +168,7 @@ Authorization: ...</pre>
168168
**Response**
169169

170170
If the [=Contract Negotiation=]'s state is successfully transitioned, the [=Provider=] _MUST_ return an HTTP code 200 (OK). The response body is
171-
not specified and clients _MUST NOT_ process it.
171+
not specified and clients _MAY_ process it.
172172

173173
### Contract Negotiation Termination Endpoint {#negotiations-providerpid-termination-post}
174174

@@ -188,7 +188,7 @@ Authorization: ...</pre>
188188
**Response**
189189

190190
If the [=Contract Negotiation=]'s state is successfully transitioned, the [=Provider=] _MUST_ return HTTP code 200 (OK). The response body is
191-
not specified and clients _MUST NOT_ process it.
191+
not specified and clients _MAY_ process it.
192192

193193
## Consumer Path Bindings
194194

@@ -284,7 +284,7 @@ Authorization: ...</pre>
284284
**Response**
285285

286286
If the message is successfully processed, the [=Consumer=] _MUST_ return an HTTP 200 (OK) response. The response body is
287-
not specified and clients _MUST NOT_ process it.
287+
not specified and clients _MAY_ process it.
288288

289289
### Contract Agreement Endpoint {#negotiations-consumerpid-agreement-post}
290290

@@ -303,7 +303,7 @@ Authorization: ...</pre>
303303
**Response**
304304

305305
If the [=Contract Negotiation=]'s state is successfully transitioned, the [=Consumer=] _MUST_ return an HTTP code 200 (OK). The response body is
306-
not specified and clients _MUST NOT_ process it.
306+
not specified and clients _MAY_ process it.
307307

308308
### Contract Negotiation Event Endpoint {#negotiations-consumerpid-events-post}
309309

@@ -322,7 +322,7 @@ Authorization: ...</pre>
322322
**Response**
323323

324324
If the [=Contract Negotiation=]'s state is successfully transitioned, the [=Consumer=] _MUST_ return HTTP code 200 (OK). The response body is
325-
not specified and clients _MUST NOT_ process it.
325+
not specified and clients _MAY_ process it.
326326

327327
### Contract Negotiation Termination Endpoint {#negotiations-consumerpid-termination-post}
328328

@@ -341,4 +341,4 @@ Authorization: ...</pre>
341341
**Response**
342342

343343
If the [=Contract Negotiation=]'s state is successfully transitioned, the [=Consumer=] _MUST_ return HTTP code 200 (OK). The response body is
344-
not specified and clients _MUST NOT_ process it.
344+
not specified and clients _MAY_ process it.

specifications/negotiation/contract.negotiation.protocol.md

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ complete [=Agreement=].
127127
- An [=Agreement=] _MUST_ contain a `timestamp` property defined as an [XSD DateTime](https://www.w3schools.com/XML/schema_dtypes_date.asp) type.
128128

129129
- An [=Agreement=] _MUST_ contain an `assigner` and `assignee`. The contents of these properties are a dataspace-specific
130-
unique identifier of the [=Agreement=] parties. These identifiers _MUST NOT_ be the same as the
130+
unique identifier of the [=Agreement=] parties. These identifiers _MAY_ be the same as the
131131
identifiers of the [=Participant Agents=] negotiating the [=Agreement=] (e.g., [=Connectors=]).
132132

133133
- An [=Agreement=] _MUST_ contain a `target` property. None of its Rules, however, _MUST_ have any `target`
@@ -239,11 +239,4 @@ An [=Agreement=] contains the following attributes:
239239
| **Properties** | <p data-include="message/table/contractnegotiationerror.html" data-include-format="html"></p> |
240240

241241
The Contract Negotiation Error is an object returned by a [=Consumer=] or [=Provider=] indicating an error has occurred.
242-
It does not cause a state transition.
243-
244-
| Field | Type | Description |
245-
|---------------|---------------|--------------------------------------------------------------|
246-
| `consumerPid` | UUID | The [=Contract Negotiation=] unique identifier on [=Consumer=] side. |
247-
| `providerPid` | UUID | The [=Contract Negotiation=] unique identifier on [=Provider=] side. |
248-
| `code` | String | An optional implementation-specific error code. |
249-
| `reason` | Array[object] | An optional array of implementation-specific error objects. |
242+
It does not cause a state transition.

specifications/transfer/transfer.process.binding.https.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ Authorization: ...</pre>
116116
**Response**
117117

118118
If the [=Transfer Process=]'s state is successfully transitioned, the [=Provider=] _MUST_ return HTTP code 200 (OK). The response body is
119-
not specified and clients _MUST NOT_ process it.
119+
not specified and clients _MAY_ process it.
120120

121121
### Transfer Completion Endpoint {#transfers-providerpid-completion-post}
122122

@@ -135,7 +135,7 @@ Authorization: ...</pre>
135135
**Response**
136136

137137
If the [=Transfer Process=]'s state is successfully transitioned, the [=Provider=] _MUST_ return HTTP code 200 (OK). The response body is
138-
not specified and clients _MUST NOT_ process it.
138+
not specified and clients _MAY_ process it.
139139

140140
### Transfer Termination Endpoint {#transfers-providerpid-termination-post}
141141

@@ -154,7 +154,7 @@ Authorization: ...</pre>
154154
**Response**
155155

156156
If the [=Transfer Process=]'s state is successfully transitioned, the [=Provider=] _MUST_ return HTTP code 200 (OK). The response body is
157-
not specified and clients _MUST NOT_ process it.
157+
not specified and clients _MAY_ process it.
158158

159159
### Transfer Suspension Endpoint {#transfers-providerpid-suspension-post}
160160

@@ -173,7 +173,7 @@ Authorization: ...</pre>
173173
**Response**
174174

175175
If the [=Transfer Process=]'s state is successfully transitioned, the [=Provider=] _MUST_ return HTTP code 200 (OK). The response body is
176-
not specified and clients _MUST NOT_ process it.
176+
not specified and clients _MAY_ process it.
177177

178178
## Consumer Callback Path Bindings
179179

@@ -211,7 +211,7 @@ Authorization: ...</pre>
211211
**Response**
212212

213213
If the [=Transfer Process=]'s state is successfully transitioned, the [=Consumer=] _MUST_ return HTTP code 200 (OK). The response body is
214-
not specified and clients _MUST NOT_ process it.
214+
not specified and clients _MAY_ process it.
215215

216216
### Transfer Completion Endpoint {#transfers-consumerpid-completion-post}
217217

@@ -230,7 +230,7 @@ Authorization: ...</pre>
230230
**Response**
231231

232232
If the [=Transfer Process=]'s state is successfully transitioned, the [=Consumer=] _MUST_ return HTTP code 200 (OK). The response body is
233-
not specified and clients _MUST NOT_ process it.
233+
not specified and clients _MAY_ process it.
234234

235235
### Transfer Termination Endpoint {#transfers-consumerpid-termination-post}
236236

@@ -249,7 +249,7 @@ Authorization: ...</pre>
249249
**Response**
250250

251251
If the [=Transfer Process=]'s state is successfully transitioned, the [=Consumer=] _MUST_ return HTTP code 200 (OK). The response body is
252-
not specified and clients _MUST NOT_ process it.
252+
not specified and clients _MAY_ process it.
253253

254254
### Transfer Suspension Endpoint {#transfers-consumerpid-suspension-post}
255255

@@ -268,4 +268,4 @@ Authorization: ...</pre>
268268
**Response**
269269

270270
If the [=Transfer Process=]'s state is successfully transitioned, the [=Consumer=] _MUST_ return HTTP code 200 (OK). The response body is
271-
not specified and clients _MUST NOT_ process it.
271+
not specified and clients _MAY_ process it.

specifications/transfer/transfer.process.protocol.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ The Transfer Request Message is sent by a [=Consumer=] to initiate a [=Transfer
117117
Note that [=Providers=] _SHOULD_ implement idempotent behavior for [Transfer Request Messages](#transfer-request-message)
118118
based on the value of `consumerPid`. [=Providers=] _MAY_ choose to implement idempotent behavior for a certain period of
119119
time. For example, until a [=Transfer Process=] has completed and been archived after an implementation-specific expiration period,
120-
repeated sending of [Transfer Request Messages](#transfer-request-message) _MUST NOT_ change the state of the [=Transfer Process=]. If a
120+
repeated sending of [Transfer Request Messages](#transfer-request-message) does not change the state of the [=Transfer Process=]. If a
121121
request for the given `consumerPid` has already been received *and* the same [=Consumer=] sent the original message
122122
again, the [=Provider=] _SHOULD_ respond with an appropriate [Transfer Start Message](#transfer-start-message).
123123

0 commit comments

Comments
 (0)