Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing CredentialDefinition validation #561

Closed
wolf4ood opened this issue Feb 7, 2025 · 0 comments · Fixed by #576
Closed

Add missing CredentialDefinition validation #561

wolf4ood opened this issue Feb 7, 2025 · 0 comments · Fixed by #576
Labels
enhancement New feature or request

Comments

@wolf4ood
Copy link
Contributor

wolf4ood commented Feb 7, 2025 •
edited
Loading

Feature Request

Currently the CredentialDefinition we only validates that the attestations linked are present in the AttestationDefinitionStore. We might want to improve and reduce possible runtime errors by validating also

  • rules

Which Areas Would Be Affected?

e.g., DPF, CI, build, transfer, etc.

Why Is the Feature Desired?

Are there any requirements?

Who will sponsor this feature?

Please @-mention the committer that will sponsor your feature.

Solution Proposal

If possible, provide a (brief!) solution proposal.
@wolf4ood wolf4ood added feature_request New feature request, awaiting triage triage all new issues awaiting classification enhancement New feature or request and removed feature_request New feature request, awaiting triage triage all new issues awaiting classification labels Feb 7, 2025
@wolf4ood wolf4ood mentioned this issue Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add rules validation on CredentialDefinition wolf4ood/IdentityHub
1 participant
@wolf4ood