Fix warnings reported by javac

Author: akurtakov

gprof/org.eclipse.linuxtools.gprof.test/src/org/eclipse/linuxtools/internal/gprof/test/STJunitUtils.java

@@ -88,8 +88,6 @@ public static boolean compareIgnoreEOL(String dumpFile, String refFile, boolean
                  fail(message + ": not correspond ");
             }
 
-            is1.close();
-            is2.close();
             // delete dump only for successful tests
             if (equals && deleteDumpFileIfOk) {
                 new File(dumpFile).delete();
@@ -143,8 +141,6 @@ public static boolean compareCSVIgnoreEOL(String dumpFile, String refFile, boole
                 }
             } while (true);
 
-            is1.close();
-            is2.close();
             if (!equals) {
                 StringBuilder msg = new StringBuilder(message + ": not correspond ");
                  msg.append("\n========= begin dump file =========\n");

libhover/org.eclipse.linuxtools.cdt.libhover.texinfoparsers/src/org/eclipse/linuxtools/cdt/libhover/texinfoparsers/ParseNewlibTexinfo.java

@@ -557,10 +557,7 @@ public static void BuildXMLFromTexinfo(String srcdir, String builddir, String ds
             BuildXMLFromTexinfo2(srcdir, builddir, os, "libm");
 
             CreateTrailer(os);
-
-            os.close();
-        }
-        catch (IOException e) {
+        } catch (IOException e) {
             System.out.println("Output File IOException: " + e);
             return;
         }

libhover/org.eclipse.linuxtools.cdt.libhover/src/org/eclipse/linuxtools/internal/cdt/libhover/LibHover.java

@@ -128,7 +128,6 @@ public static void saveLibraries(IPath locationBase, IPreferenceStore ps) {
                         try (FileOutputStream f = new FileOutputStream(locationDir.append("tmpFile").toOSString()); //$NON-NLS-1$
                                 ObjectOutputStream out = new ObjectOutputStream(f)) {
                             out.writeObject(l.getHoverInfo());
-                            out.close();
                             File tmp = new File(locationDir.append("tmpFile").toOSString()); //$NON-NLS-1$
                             tmp.renameTo(target);
                         }

profiling/org.eclipse.linuxtools.ssh.proxy/src/org/eclipse/linuxtools/internal/ssh/proxy/SSHProxyManager.java

@@ -95,7 +95,6 @@ public Map<String, String> getEnv(URI uri) throws CoreException {
             if((errorLine = error.readLine()) != null){
                 throw new IOException(errorLine);
             }
-            error.close();
         } catch (IOException e) {
 			Activator.getDefault().getLog().log(Status.error(e.getMessage(), e));
             return Collections.emptyMap();

systemtap/org.eclipse.linuxtools.callgraph.core/src/org/eclipse/linuxtools/internal/callgraph/core/Helper.java

@@ -1,6 +1,6 @@
 /*******************************************************************************
  * Copyright (c) 2009, 2018 Red Hat, Inc.
- * 
+ *
  * This program and the accompanying materials are made
  * available under the terms of the Eclipse Public License 2.0
  * which is available at https://www.eclipse.org/legal/epl-2.0/
@@ -15,7 +15,6 @@
 import java.io.BufferedReader;
 import java.io.BufferedWriter;
 import java.io.File;
-import java.io.FileNotFoundException;
 import java.io.FileReader;
 import java.io.FileWriter;
 import java.io.IOException;
@@ -53,11 +52,7 @@ public static String readFile(String absoluteFilePath) {
             while ((tmp = bw.readLine()) != null) {
                 output+=tmp + "\n"; //$NON-NLS-1$
             }
-            bw.close();
-
             return output;
-        } catch (FileNotFoundException e) {
-            e.printStackTrace();
         } catch (IOException e) {
             e.printStackTrace();
         }
@@ -69,8 +64,7 @@ public static BufferedWriter setBufferedWriter(String absoluteFilePath) {
             File f = new File(absoluteFilePath);
             f.delete();
             f.createNewFile();
-            FileWriter fstream;
-            fstream = new FileWriter(absoluteFilePath, true);
+            FileWriter fstream = new FileWriter(absoluteFilePath, true);
             return new BufferedWriter(fstream);
         } catch (IOException e) {
             SystemTapUIErrorMessages err = new SystemTapUIErrorMessages

systemtap/org.eclipse.linuxtools.callgraph.core/src/org/eclipse/linuxtools/internal/callgraph/core/SystemTapErrorHandler.java

@@ -54,7 +54,7 @@ public void handle(IProgressMonitor m, String errors) {
 
         // READ FROM THE PROP FILE AND DETERMINE TYPE OF ERROR
         File file = new File(PluginConstants.getPluginLocation() + FILE_PROP);
-        try (BufferedReader buff1 = new BufferedReader(new FileReader(file))) {
+		try {
             String line;
             for (String message : errorsList) {
                 try (BufferedReader innerBuff = new BufferedReader(

systemtap/org.eclipse.linuxtools.callgraph.launch/src/org/eclipse/linuxtools/internal/callgraph/launch/LaunchStapGraph.java

@@ -164,7 +164,6 @@ private String writeFromPartialScript(String projectName) throws IOException {
             while ((temp = scriptReader.readLine()) != null) {
                 toWrite += temp + "\n"; //$NON-NLS-1$
             }
-            scriptReader.close();
         }
 
         return toWrite;

systemtap/org.eclipse.linuxtools.systemtap.graphing.core/src/org/eclipse/linuxtools/systemtap/graphing/core/datasets/table/TableDataSet.java

@@ -67,7 +67,6 @@ public boolean readFromFile(File file) {
                     entry.add(line.split(", ")); //$NON-NLS-1$
                 }
             }
-            br.close();
             return true;
         } catch(IOException|ArrayIndexOutOfBoundsException e) {}
         return false;

systemtap/org.eclipse.linuxtools.systemtap.ui.ide.tests/src/org/eclipse/linuxtools/systemtap/ui/ide/test/editors/stp/STPCompletionProcessorTest.java

@@ -18,10 +18,8 @@
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
-import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
-import java.io.OutputStream;
 import java.nio.file.Files;
 import java.nio.file.StandardCopyOption;
 
@@ -82,8 +80,7 @@ public static void prepareTrees() {
 		path = path.append("TreeSettings").addFileExtension("xml"); //$NON-NLS-1$ //$NON-NLS-2$
 
 		try (InputStream is = FileLocator.openStream(FrameworkUtil.getBundle(STPCompletionProcessorTest.class),
-				new Path("helpers/TreeSettings.xml"), false);
-				OutputStream outStream = new FileOutputStream(path.toFile())) {
+				new Path("helpers/TreeSettings.xml"), false)) {
 			Files.copy(is, path.toFile().toPath(), StandardCopyOption.REPLACE_EXISTING);
 			TapsetLibrary.readTreeFile();
 		} catch (IOException e) {

systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/editors/stp/STPEditor.java

@@ -185,7 +185,6 @@ public void doSaveAs() {
         try (FileOutputStream fos = new FileOutputStream(file);
                 PrintStream ps = new PrintStream(fos)){
             ps.print(s);
-            ps.close();
         } catch (IOException fnfe) {
             // Pass
         }