Remove unnecessary casts

The rest of the change is save actions modernizing code.

Author: akurtakov

Diff for: libhover/org.eclipse.linuxtools.cdt.libhover/src/org/eclipse/linuxtools/internal/cdt/libhover/LibHover.java

@@ -390,12 +390,12 @@ public IFunctionSummary getFunctionInfo(ICHelpInvocationContext context, ICHelpB
                     if (result[0] != null) {
                         final IBinding binding = result[0].getBinding();
                         // Check to see we have a member function.
-                        if (binding instanceof ICPPFunction) {
-                            methodType = ((ICPPFunction)binding).getType();
+                        if (binding instanceof ICPPFunction cppfunction) {
+                            methodType = cppfunction.getType();
                             // We have a member function, find the class name.
-                            IBinding owner = ((ICPPFunction)binding).getOwner();
-                            if (owner instanceof ICPPClassType) {
-                                className = getClassName((ICPPClassType)owner);
+                            IBinding owner = cppfunction.getOwner();
+                            if (owner instanceof ICPPClassType classType) {
+                                className = getClassName(classType);
                             }
                         }
                     }

Diff for: perf/org.eclipse.linuxtools.perf/src/org/eclipse/linuxtools/internal/perf/ui/PerfDoubleClickAction.java

@@ -46,7 +46,7 @@ public void run() {
         try {
             if (obj instanceof PMLineRef line) {
                 // Open in editor
-                PMFile file = (PMFile) ((PMSymbol) line.getParent()).getParent();
+                PMFile file = (PMFile) line.getParent().getParent();
                 ProfileUIUtils.openEditorAndSelect(file.getPath(),Integer.parseInt(line.getName()), PerfPlugin.getDefault().getProfiledProject());
             } else if (obj instanceof PMFile file) {
                 ProfileUIUtils.openEditorAndSelect(file.getName(), 1);

Diff for: rpm/org.eclipse.linuxtools.rpm.ui.editor.tests/src/org/eclipse/linuxtools/rpm/ui/editor/tests/HeaderRecognitionTest.java

@@ -34,7 +34,7 @@ public void testGetSimpleSectionName() {
 		newFile(testText);
 		element = parser.parseLine(testText, specfile, 0);
 		assertEquals(SpecfileSection.class, element.getClass());
-		assertEquals(testText.substring(1), ((SpecfileSection) element).getName());
+		assertEquals(testText.substring(1), element.getName());
 	}
 
 	@Test

Diff for: rpm/org.eclipse.linuxtools.rpm.ui.editor.tests/src/org/eclipse/linuxtools/rpm/ui/editor/tests/parser/SpecfileDefineTest.java

@@ -21,7 +21,6 @@
 import org.eclipse.linuxtools.rpm.core.utils.RPMQuery;
 import org.eclipse.linuxtools.rpm.ui.editor.markers.SpecfileErrorHandler;
 import org.eclipse.linuxtools.rpm.ui.editor.parser.SpecfileDefine;
-import org.eclipse.linuxtools.rpm.ui.editor.parser.SpecfileElement;
 import org.eclipse.linuxtools.rpm.ui.editor.tests.FileTestCase;
 import org.eclipse.linuxtools.rpm.ui.editor.tests.SpecfileTestFailure;
 import org.junit.Before;
@@ -64,7 +63,7 @@ public void testResolve() {
 		SpecfileDefine define1 = new SpecfileDefine("name", "testspec", specfile,
 				specfile.getPackages().getPackage(specfile.getName()));
 		specfile.addDefine(define1);
-		assertEquals("testspec", ((SpecfileElement) define1).resolve("%{name}"));
+		assertEquals("testspec", define1.resolve("%{name}"));
 	}
 
 	@Test

Diff for: systemtap/org.eclipse.linuxtools.systemtap.graphing.ui/src/org/eclipse/linuxtools/systemtap/graphing/ui/datadisplay/DataGrid.java

@@ -1,6 +1,6 @@
 /*******************************************************************************
  * Copyright (c) 2006, 2018 IBM Corporation and others.
- * 
+ *
  * This program and the accompanying materials are made
  * available under the terms of the Eclipse Public License 2.0
  * which is available at https://www.eclipse.org/legal/epl-2.0/
@@ -139,10 +139,10 @@ private Menu initMenus() {
 
         IDataSetFilter[] filters = filteredDataSet.getFilters();
         if (filters != null && filters.length > 0) {
-            for (int i = 0; i < filters.length; i++) {
+            for (IDataSetFilter filter : filters) {
                 item = new MenuItem(filterMenu, SWT.CASCADE);
-                item.setText(AvailableFilterTypes.getFilterName(filters[i].getID()));
-                item.setData(filters[i]);
+                item.setText(AvailableFilterTypes.getFilterName(filter.getID()));
+                item.setData(filter);
                 item.addSelectionListener(new RemoveFilterSelection());
             }
         } else {
@@ -156,9 +156,9 @@ private Menu initMenus() {
         jumpToEntryMenuItem.setText(Localization.getString("DataGrid.JumpToEntry")); //$NON-NLS-1$
         jumpToEntryMenuItem.setSelection(prefs.getBoolean(GraphingPreferenceConstants.P_JUMP_NEW_TABLE_ENTRY));
 
-        for (int i = 0; i < IFormattingStyles.FORMAT_TITLES.length; i++) {
+        for (String element : IFormattingStyles.FORMAT_TITLES) {
             item = new MenuItem(formatMenu, SWT.RADIO);
-            item.setText(IFormattingStyles.FORMAT_TITLES[i]);
+            item.setText(element);
             item.addSelectionListener(new MenuFormatSelection());
         }
 
@@ -209,7 +209,7 @@ public void widgetSelected(SelectionEvent e) {
     private class RemoveFilterSelection implements SelectionListener {
         @Override
         public void widgetSelected(SelectionEvent e) {
-            IDataSetFilter idsf = (IDataSetFilter)((MenuItem)e.widget).getData();
+			IDataSetFilter idsf = (IDataSetFilter) e.widget.getData();
             e.widget.dispose();
             if (filterMenu.getItemCount() == 0) {
                 removeFiltersMenuItem.setEnabled(false);
@@ -234,8 +234,8 @@ public void menuShown(MenuEvent e) {
 
             int selectedCol = Math.max(1, getSelectedColumn());
 
-            for (int i = 0; i < items.length; i++) {
-                items[i].setSelection(false);
+            for (MenuItem item : items) {
+                item.setSelection(false);
             }
             items[columnFormat[selectedCol-1].getFormat()].setSelection(true);