m2e-core depends on LifecycleExecutionPlanCalculatorFacade #2085
Conversation
This was introduced in Maven Runtime bundle in version 3.9.1101 with commit 996c2d7
kwin
force-pushed
the
bugfix/adjust-import-versions-for-maven-runtime
branch
from
a745fe2 to
6b8ff78
Compare
Can you tell where exactly this is the case? |
|
996c2d7 introduced it. |
|
How to adjust the m2e-runtimes.target for the SNAPSHOT version or do we need to release maven-runtime individually? |
Test Results 218 files ±0 218 suites ±0 45m 25s ⏱️ +4s For more details on these failures and errors, see this check. Results for commit 6b8ff78. ± Comparison against base commit 2bac0fc. |
|
@laeubi Can you have a look? |
This is currently on goign work to support maven4 and might be subject to change
I'm not sure what exactly you mean? The target contains old (historic) runtimes and we not modify / update them. But as you see it becomes harder now to support older runtimes per se, and maven itself seem to lean towards Maven 3.9 as a new baseline for their core plugins so we can think about dropping the 3.8.x runtime. It just worked so far to use it ... |
|
The target defines an Eclipse baseline m2e is compatible with. This is not the case for Maven Runtime. We should fix one way or the other: Revert changes which require a newer Maven Runtime or release a new Maven Runtime and then require at least this version. The current status quo is just broken... |
I'm not completely sure what you mean... is there any build/test failing? The whole purpose of the runtime is to abstract some version specific thing, so m2e-core should never require any changes (but maybe an older runtime needs to be fixed). |
|
m2e-core requires LifecycleExecutionPlanCalculatorFacade which is not available in the lowest version required according to the require bundle version range! Also not everyone has runtime in the Eclipse Workspace. I don't and therefore rely on the version being provided by target when I test drive the latest m2e version. |
Then you need to update your SDK... the runtime targets are only provided as best effort and for users that can't use new Maven versions, so even if this change would be merged it wont help you as the latest maven-runtime is never part of the target. |
In this case older versions are known to be incompatible with latest m2e-core. Therefore we should not add maven runtime to target if newest (unreleased) version is needed. In any case the version range should be fixed! Otherwise the OSGi metadata is just incorrect! |
This was introduced in Maven Runtime bundle in version 3.9.1101