temp commit - review comments

Author: dylanjtuttle

compiler/codegen/Relocation.hpp

@@ -424,17 +424,17 @@ class ExternalRelocation : public TR::Relocation
    virtual bool isExternalRelocation() { return true; }
 
    static const char *getName(TR_ExternalRelocationTargetKind k) {return _externalRelocationTargetKindNames[k];}
-   static uintptr_t    getGlobalValue(uint32_t g)
+   static uintptr_t   getGlobalValue(uint32_t g)
          {
          TR_ASSERT(g >= 0 && g < TR_NumGlobalValueItems, "invalid index for global item");
          return _globalValueList[g];
          }
-   static const void         setGlobalValue(uint32_t g, uintptr_t v)
+   static void        setGlobalValue(uint32_t g, uintptr_t v)
          {
          TR_ASSERT(g >= 0 && g < TR_NumGlobalValueItems, "invalid index for global item");
          _globalValueList[g] = v;
          }
-   static const char *       nameOfGlobal(uint32_t g)
+   static const char *nameOfGlobal(uint32_t g)
          {
          TR_ASSERT(g >= 0 && g < TR_NumGlobalValueItems, "invalid index for global item");
          return _globalValueNames[g];

compiler/optimizer/OrderBlocks.cpp

@@ -1256,7 +1256,7 @@ bool TR_OrderBlocks::peepHoleBranchToLoopHeader(TR::CFG *cfg, TR::Block *block,
 // apply peephole optimizations to blocks that end in a branch and branch around a single goto
 void TR_OrderBlocks::peepHoleBranchAroundSingleGoto(TR::CFG *cfg, TR::Block *block, const char *title)
    {
-   TR_ASSERT(block->endsInBranch(), "peepHoleBranchBlock called on block that doesn't end in a branch!");
+   TR_ASSERT(block->endsInBranch(), "peepHoleBranchAroundSingleGoto called on block that doesn't end in a branch!");
    TR::Node *branchNode = block->getLastRealTreeTop()->getNode();
    TR::TreeTop *takenEntry = branchNode->getBranchDestination();
    TR::Block *takenBlock = takenEntry->getNode()->getBlock();