diff --git a/jcl/src/java.base/share/classes/java/lang/System.java b/jcl/src/java.base/share/classes/java/lang/System.java
index cd3139854f6..56590c938e1 100644
--- a/jcl/src/java.base/share/classes/java/lang/System.java
+++ b/jcl/src/java.base/share/classes/java/lang/System.java
@@ -1350,7 +1350,7 @@ public static void setSecurityManager(final SecurityManager s) {
/*[IF JAVA_SPEC_VERSION >= 24]*/
/*[MSG "K0B03", "Setting a Security Manager is not supported"]*/
throw new UnsupportedOperationException(Msg.getString("K0B03")); //$NON-NLS-1$
-/*[ELSE] JAVA_SPEC_VERSION >= 24*/
+/*[ELSE] JAVA_SPEC_VERSION >= 24 */
/*[IF CRIU_SUPPORT]*/
if (openj9.internal.criu.InternalCRIUSupport.isCRIUSupportEnabled()) {
/*[MSG "K0B02", "Enabling a SecurityManager currently unsupported when -XX:+EnableCRIUSupport is specified"]*/
@@ -1428,7 +1428,7 @@ public Void run() {
currentSecurity.checkPermission(com.ibm.oti.util.RuntimePermissions.permissionSetSecurityManager);
}
security = s;
-/*[ENDIF] JAVA_SPEC_VERSION >= 24*/
+/*[ENDIF] JAVA_SPEC_VERSION >= 24 */
}
/**
diff --git a/jcl/src/java.base/share/classes/java/security/AccessController.java b/jcl/src/java.base/share/classes/java/security/AccessController.java
index af767199ed5..f1bbeb38da7 100644
--- a/jcl/src/java.base/share/classes/java/security/AccessController.java
+++ b/jcl/src/java.base/share/classes/java/security/AccessController.java
@@ -47,7 +47,7 @@
/*[ENDIF] JAVA_SPEC_VERSION >= 17 */
public final class AccessController {
/*[IF JAVA_SPEC_VERSION >= 24]*/
- private static AccessControlContext ACC_NO_PERM = new AccessControlContext(
+ private static final AccessControlContext ACC_NO_PERM = new AccessControlContext(
new ProtectionDomain[] { new ProtectionDomain(null, null) });
/*[ELSE] JAVA_SPEC_VERSION >= 24 */
static {
@@ -654,7 +654,6 @@ private static int getNewAuthorizedState(AccessControlContext acc, ProtectionDom
}
return newAuthorizedState;
}
-/*[ENDIF] JAVA_SPEC_VERSION < 24 */
/**
* Helper method to combine the ProtectionDomain objects
@@ -722,6 +721,7 @@ static ProtectionDomain[] toArrayOfProtectionDomains(Object[] domains, AccessCon
return answer;
}
+/*[ENDIF] JAVA_SPEC_VERSION < 24 */
/**
* Performs the privileged action specified by action
.
@@ -770,12 +770,15 @@ public static T doPrivileged(PrivilegedAction action) {
*/
@CallerSensitive
public static T doPrivileged(PrivilegedAction action, AccessControlContext context) {
+ /*[IF JAVA_SPEC_VERSION >= 24]*/
+ return action.run();
+ /*[ELSE] JAVA_SPEC_VERSION >= 24 */
T result = action.run();
- /*[IF JAVA_SPEC_VERSION < 24]*/
/*[PR 108112] context is not kept alive*/
keepalive(context);
- /*[ENDIF] JAVA_SPEC_VERSION < 24 */
return result;
+ /*[ENDIF] JAVA_SPEC_VERSION >= 24 */
+
}
/**
@@ -839,12 +842,14 @@ public static T doPrivileged (PrivilegedExceptionAction action, AccessCon
throws PrivilegedActionException
{
try {
+ /*[IF JAVA_SPEC_VERSION >= 24]*/
+ return action.run();
+ /*[ELSE] JAVA_SPEC_VERSION >= 24 */
T result = action.run();
- /*[IF JAVA_SPEC_VERSION < 24]*/
/*[PR 108112] context is not kept alive*/
keepalive(context);
- /*[ENDIF] JAVA_SPEC_VERSION < 24 */
return result;
+ /*[ENDIF] JAVA_SPEC_VERSION >= 24 */
} catch (RuntimeException ex) {
throw ex;
} catch (Exception ex) {
@@ -873,9 +878,9 @@ public static T doPrivileged (PrivilegedExceptionAction action, AccessCon
public static T doPrivilegedWithCombiner(PrivilegedAction action) {
/*[IF JAVA_SPEC_VERSION >= 24]*/
return doPrivileged(action, null);
-/*[ELSE] JAVA_SPEC_VERSION >= 24*/
+/*[ELSE] JAVA_SPEC_VERSION >= 24 */
return doPrivileged(action, doPrivilegedWithCombinerHelper(null));
-/*[ENDIF] JAVA_SPEC_VERSION >= 24*/
+/*[ENDIF] JAVA_SPEC_VERSION >= 24 */
}
/**
@@ -904,9 +909,9 @@ public static T doPrivilegedWithCombiner(PrivilegedExceptionAction action
{
/*[IF JAVA_SPEC_VERSION >= 24]*/
return doPrivileged(action, null);
-/*[ELSE] JAVA_SPEC_VERSION >= 24*/
+/*[ELSE] JAVA_SPEC_VERSION >= 24 */
return doPrivileged(action, doPrivilegedWithCombinerHelper(null));
-/*[ENDIF] JAVA_SPEC_VERSION >= 24*/
+/*[ENDIF] JAVA_SPEC_VERSION >= 24 */
}
/*[IF JAVA_SPEC_VERSION < 24]*/
@@ -954,15 +959,15 @@ private static void checkPermsNPE(Permission... perms) {
public static T doPrivileged(PrivilegedAction action,
AccessControlContext context, Permission... perms)
{
-/*[IF JAVA_SPEC_VERSION < 24]*/
- checkPermsNPE(perms);
-/*[ENDIF] JAVA_SPEC_VERSION < 24 */
- T result = action.run();
-/*[IF JAVA_SPEC_VERSION < 24]*/
- keepalive(context);
- keepalive(perms);
-/*[ENDIF] JAVA_SPEC_VERSION < 24 */
- return result;
+ /*[IF JAVA_SPEC_VERSION >= 24] */
+ return action.run();
+ /*[ELSE] JAVA_SPEC_VERSION >= 24 */
+ checkPermsNPE(perms);
+ T result = action.run();
+ keepalive(context);
+ keepalive(perms);
+ return result;
+ /*[ENDIF] JAVA_SPEC_VERSION >= 24 */
}
/**
@@ -991,12 +996,11 @@ public static T doPrivilegedWithCombiner(PrivilegedAction action,
AccessControlContext context, Permission... perms)
{
/*[IF JAVA_SPEC_VERSION >= 24]*/
- return doPrivileged(action, context, perms); // 24 - perms?
-/*[ELSE] JAVA_SPEC_VERSION >= 24*/
+ return doPrivileged(action, context, perms);
+/*[ELSE] JAVA_SPEC_VERSION >= 24 */
checkPermsNPE(perms);
return doPrivileged(action, doPrivilegedWithCombinerHelper(context), perms);
-/*[ENDIF] JAVA_SPEC_VERSION >= 24*/
-
+/*[ENDIF] JAVA_SPEC_VERSION >= 24 */
}
/**
@@ -1030,15 +1034,15 @@ public static T doPrivileged(PrivilegedExceptionAction action,
throws PrivilegedActionException
{
try {
-/*[IF JAVA_SPEC_VERSION < 24]*/
+ /*[IF JAVA_SPEC_VERSION >= 24]*/
+ return action.run();
+ /*[ELSE] JAVA_SPEC_VERSION >= 24 */
checkPermsNPE(perms);
-/*[ENDIF] JAVA_SPEC_VERSION < 24 */
T result = action.run();
-/*[IF JAVA_SPEC_VERSION < 24]*/
keepalive(context);
keepalive(perms);
-/*[ENDIF] JAVA_SPEC_VERSION < 24 */
return result;
+ /*[ENDIF] JAVA_SPEC_VERSION >= 24 */
} catch (RuntimeException ex) {
throw ex;
} catch (Exception ex) {
@@ -1102,6 +1106,6 @@ private static AccessControlContext doPrivilegedWithCombinerHelper(AccessControl
}
return fixedContext;
}
-/*[ENDIF] JAVA_SPEC_VERSION < 24*/
+/*[ENDIF] JAVA_SPEC_VERSION < 24 */
}
diff --git a/runtime/jcl/common/java_lang_Class.cpp b/runtime/jcl/common/java_lang_Class.cpp
index 440f0dde3af..839946d4c9b 100644
--- a/runtime/jcl/common/java_lang_Class.cpp
+++ b/runtime/jcl/common/java_lang_Class.cpp
@@ -44,7 +44,7 @@ typedef enum {
STATE_IMPLIED = 1
} StackWalkingStates;
-#define STACK_WALK_STATE_MAGIC (void *)1
+#define STACK_WALK_STATE_MAGIC ((void *)1)
#if JAVA_SPEC_VERSION < 24
typedef enum {
@@ -54,8 +54,8 @@ typedef enum {
OBJS_ARRAY_SIZE = 3
} ObjsArraySizeNindex;
-#define STACK_WALK_STATE_LIMITED_DOPRIVILEGED (void *)2
-#define STACK_WALK_STATE_FULL_DOPRIVILEGED (void *)3
+#define STACK_WALK_STATE_LIMITED_DOPRIVILEGED ((void *)2)
+#define STACK_WALK_STATE_FULL_DOPRIVILEGED ((void *)3)
static UDATA isPrivilegedFrameIterator(J9VMThread * currentThread, J9StackWalkState * walkState);
static UDATA isPrivilegedFrameIteratorGetAccSnapshot(J9VMThread * currentThread, J9StackWalkState * walkState);
diff --git a/test/functional/cmdLineTests/shareClassTests/DataHelperTests/DataHelperTests.xml b/test/functional/cmdLineTests/shareClassTests/DataHelperTests/DataHelperTests.xml
index 52ff13aadb3..0958998514f 100644
--- a/test/functional/cmdLineTests/shareClassTests/DataHelperTests/DataHelperTests.xml
+++ b/test/functional/cmdLineTests/shareClassTests/DataHelperTests/DataHelperTests.xml
@@ -54,13 +54,13 @@
-
+
-
+
-
+
diff --git a/test/functional/cmdLineTests/shareClassTests/DataHelperTests/DataHelperTests_SecurityManager.xml b/test/functional/cmdLineTests/shareClassTests/DataHelperTests/DataHelperTests_SecurityManager.xml
index 8748810f68a..22edc7b6a39 100644
--- a/test/functional/cmdLineTests/shareClassTests/DataHelperTests/DataHelperTests_SecurityManager.xml
+++ b/test/functional/cmdLineTests/shareClassTests/DataHelperTests/DataHelperTests_SecurityManager.xml
@@ -1,25 +1,25 @@
@@ -54,13 +54,13 @@
-
+
-
+
-
+