Skip to content

Commit bfca583

Browse files
authored
Merge pull request #18741 from keithc-ca/JVM_VirtualThreadDisableSuspend
Make JVM_VirtualThreadDisableSuspend() available for jdk22
2 parents d8c771e + 60dcc42 commit bfca583

File tree

5 files changed

+5
-17
lines changed

5 files changed

+5
-17
lines changed

runtime/j9vm/exports.cmake

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -442,11 +442,6 @@ if(JAVA_SPEC_VERSION LESS 22)
442442
else()
443443
jvm_add_exports(jvm
444444
JVM_ExpandStackFrameInfo
445-
)
446-
endif()
447-
448-
if(NOT JAVA_SPEC_VERSION LESS 23)
449-
jvm_add_exports(jvm
450445
JVM_VirtualThreadDisableSuspend
451446
)
452447
endif()

runtime/j9vm/j9vmnatives.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -450,10 +450,6 @@ SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0-only WITH Classpath-ex
450450
<exports group="jdk22">
451451
<!-- Additions for Java 22 (General) -->
452452
<export name="JVM_ExpandStackFrameInfo"/>
453-
</exports>
454-
455-
<exports group="jdk23">
456-
<!-- Additions for Java 23 (General) -->
457453
<export name="JVM_VirtualThreadDisableSuspend"/>
458454
</exports>
459455
</exportlists>

runtime/j9vm/javanextvmi.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -724,14 +724,14 @@ JVM_ExpandStackFrameInfo(JNIEnv *env, jobject object)
724724
{
725725
assert(!"JVM_ExpandStackFrameInfo unimplemented");
726726
}
727-
#endif /* JAVA_SPEC_VERSION >= 22 */
728727

729-
#if JAVA_SPEC_VERSION >= 23
730728
JNIEXPORT void JNICALL
731729
JVM_VirtualThreadDisableSuspend(JNIEnv *env, jobject vthread, jboolean enter)
732730
{
733-
assert(!"JVM_VirtualThreadDisableSuspend unimplemented");
731+
/* TODO: Add implementation.
732+
* See https://github.com/eclipse-openj9/openj9/issues/18671 for more details.
733+
*/
734734
}
735-
#endif /* JAVA_SPEC_VERSION >= 23 */
735+
#endif /* JAVA_SPEC_VERSION >= 22 */
736736

737737
} /* extern "C" */

runtime/j9vm/module.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,6 @@ SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0-only WITH Classpath-ex
8585
<group name="jdk22">
8686
<include-if condition="spec.java22"/>
8787
</group>
88-
<group name="jdk23">
89-
<include-if condition="spec.java23"/>
90-
</group>
9188
</exports>
9289
<includes>
9390
<include path="j9include"/>

runtime/redirector/forwarders.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,5 +428,5 @@ _IF([defined(J9VM_OPT_VALHALLA_VALUE_TYPES)],
428428
[_X(JVM_IsValhallaEnabled, JNICALL, false, jboolean, void)])
429429
_IF([JAVA_SPEC_VERSION >= 22],
430430
[_X(JVM_ExpandStackFrameInfo, JNICALL, false, void, JNIEnv *env, jobject object)])
431-
_IF([JAVA_SPEC_VERSION >= 23],
431+
_IF([JAVA_SPEC_VERSION >= 22],
432432
[_X(JVM_VirtualThreadDisableSuspend, JNICALL, false, void, JNIEnv *env, jobject vthread, jboolean enter)])

0 commit comments

Comments
 (0)