Skip to content

Commit f3e9891

Browse files
authored
Merge pull request #20928 from midronij/openxl-config
Fix OMR_ENV_OPENXL Usage
2 parents 5f1df29 + 254419d commit f3e9891

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

runtime/gc_glue_java/configure_includes/configure_aix_ppc.mk

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,13 @@ CONFIGURE_ARGS += 'AR=$(AR)'
7676
CONFIGURE_ARGS += 'OMR_HOST_OS=aix'
7777
CONFIGURE_ARGS += 'OMR_HOST_ARCH=ppc'
7878
CONFIGURE_ARGS += 'OMR_TARGET_DATASIZE=$(TEMP_TARGET_DATASIZE)'
79-
CONFIGURE_ARGS += 'OMR_TOOLCHAIN=xlc'
80-
ifeq ($(OMR_ENV_OPENXL),1)
79+
80+
ifneq (,$(findstring ibm-clang,$(notdir $(CC))))
81+
CONFIGURE_ARGS += 'OMR_TOOLCHAIN=openxl'
8182
CONFIGURE_ARGS += 'GLOBAL_CFLAGS=-fstack-protector'
8283
CONFIGURE_ARGS += 'GLOBAL_CXXFLAGS=-fstack-protector'
8384
else
85+
CONFIGURE_ARGS += 'OMR_TOOLCHAIN=xlc'
8486
CONFIGURE_ARGS += 'GLOBAL_CFLAGS=-qstackprotect'
8587
CONFIGURE_ARGS += 'GLOBAL_CXXFLAGS=-qstackprotect'
8688
endif

runtime/makelib/targets.mk.aix.inc.ftl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ endif
5555
ifeq ($(j9vm_env_data64),1)
5656
UMA_ASPP_DEBUG += -g
5757
UMA_LIB_LINKER_FLAGS += -X64
58-
ifeq ($(OMR_ENV_OPENXL),1)
58+
ifeq (openxl,$(OMR_TOOLCHAIN))
5959
UMA_CC_MODE += -m64
6060
else
6161
UMA_CC_MODE += -q64
@@ -102,7 +102,7 @@ else
102102
endif
103103

104104
ifeq (,$(findstring xlclang,$(notdir $(CC))))
105-
ifeq ($(OMR_ENV_OPENXL),1)
105+
ifeq (openxl,$(OMR_TOOLCHAIN))
106106
# for openxl do nothing
107107
else
108108
# xlc options
@@ -112,7 +112,7 @@ else
112112
# xlclang options
113113
CFLAGS += -qxlcompatmacros
114114
endif
115-
ifeq ($(OMR_ENV_OPENXL),1)
115+
ifeq (openxl,$(OMR_TOOLCHAIN))
116116
#openxl options
117117
CFLAGS += -std=c89 -qarch=ppc -fno-strict-aliasing -fstack-protector
118118
else
@@ -127,7 +127,7 @@ else
127127
endif
128128

129129
ifeq (,$(findstring xlclang++,$(notdir $(CXX))))
130-
ifeq ($(OMR_ENV_OPENXL),1)
130+
ifeq (openxl,$(OMR_TOOLCHAIN))
131131
# openxl options
132132
CXXFLAGS += -fno-rtti -fno-exceptions
133133
else
@@ -138,7 +138,7 @@ else
138138
# xlclang++ options
139139
CXXFLAGS += -qxlcompatmacros -fno-rtti -fno-exceptions
140140
endif
141-
ifeq ($(OMR_ENV_OPENXL),1)
141+
ifeq (openxl,$(OMR_TOOLCHAIN))
142142
# openxl options
143143
CXXFLAGS += -std=c++11 -qarch=ppc -fno-strict-aliasing -fstack-protector
144144
else
@@ -166,7 +166,7 @@ endif
166166
UMA_SYS_LINK_PATH := -L/usr/lib/threads
167167

168168
ifeq ($(j9vm_env_data64),1)
169-
ifeq ($(OMR_ENV_OPENXL),1)
169+
ifeq (openxl,$(OMR_TOOLCHAIN))
170170
UMA_DLL_LINK_FLAGS += -m64
171171
else
172172
UMA_DLL_LINK_FLAGS += -q64
@@ -205,7 +205,7 @@ $(patsubst %.s,%.o,$(filter %.s,$(UMA_FILES_TO_PREPROCESS))) : %$(UMA_DOT_O) : %
205205

206206
ifdef UMA_TREAT_WARNINGS_AS_ERRORS
207207
ifndef UMA_SUPPRESS_WARNINGS_AS_ERRORS
208-
ifeq ($(OMR_ENV_OPENXL),1)
208+
ifeq (openxl,$(OMR_TOOLCHAIN))
209209
CFLAGS += -Werror
210210
CXXFLAGS += -Werror
211211
else

0 commit comments

Comments
 (0)