Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support restore with -XX:CRaCRestoreFrom=PATH #19261

Closed
singh264 opened this issue Apr 2, 2024 · 4 comments
Closed

Support restore with -XX:CRaCRestoreFrom=PATH #19261

singh264 opened this issue Apr 2, 2024 · 4 comments
Assignees
@singh264
Labels
criu Used to track CRIU snapshot related work
Milestone
Release 0.48 (Jav...

Comments

@singh264
Copy link
Contributor

singh264 commented Apr 2, 2024

The documentation about restoring a checkpoint image with -XX:CRaCRestoreFrom=PATH is at https://github.com/CRaC/docs.
@singh264 singh264 added the criu Used to track CRIU snapshot related work label Apr 2, 2024
@singh264
Copy link
Contributor Author

singh264 commented Apr 2, 2024

@tajila I would like to address this issue.

singh264 added a commit to singh264/openj9-openjdk-jdk21 that referenced this issue Apr 17, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
d1a2e9c 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
@singh264 singh264 mentioned this issue Apr 17, 2024
Closed
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Apr 19, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
eae55d4 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
@singh264 singh264 mentioned this issue Apr 19, 2024
Merged
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Apr 23, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
531be0f 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Apr 23, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
8cffc29 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Apr 23, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
e1deb53 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Apr 26, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
3f0c408 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Apr 26, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
75fb4af 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
JasonFengJ9 pushed a commit to JasonFengJ9/openj9-openjdk-jdk that referenced this issue Apr 29, 2024
@singh264 @JasonFengJ9
Support restore with -XX:CRaCRestoreFrom=PATH
9b29eda 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue May 6, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
bcfff08 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue May 6, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
30a7354 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue May 30, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
0c74810 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue May 30, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
c0704d3 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Jun 3, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
4ee4e05 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Jun 3, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
9a7a96c 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/omr that referenced this issue Jun 6, 2024
@singh264 @JasonFengJ9 @keithc-ca
Update the coding standard
113bebf 
Issue: eclipse-openj9/openj9#19261
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
@singh264 singh264 mentioned this issue Jun 6, 2024
Merged
singh264 added a commit to singh264/omr that referenced this issue Jun 6, 2024
@singh264 @JasonFengJ9 @keithc-ca
Update the coding standard
00717e3 
Issue: eclipse-openj9/openj9#19261
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/omr that referenced this issue Jun 6, 2024
@singh264 @JasonFengJ9 @keithc-ca
Update the coding standard
58e6fcd 
Issue: eclipse-openj9/openj9#19261
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/omr that referenced this issue Jun 6, 2024
@singh264 @JasonFengJ9
@keithc-ca @babsingh
Update the coding standard
ec35cb5 
Issue: eclipse-openj9/openj9#19261
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Co-authored-by: Babneet Singh <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/omr that referenced this issue Jun 7, 2024
@singh264 @JasonFengJ9
@keithc-ca @babsingh
Update the coding standard
c946ec7 
Issue: eclipse-openj9/openj9#19261
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Co-authored-by: Babneet Singh <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/omr that referenced this issue Jun 7, 2024
@singh264 @JasonFengJ9
@keithc-ca @babsingh
Update the coding standard
c4f7cbf 
Issue: eclipse-openj9/openj9#19261
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Co-authored-by: Babneet Singh <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Jun 7, 2024
@singh264
Support restore with -XX:CRaCRestoreFrom=PATH
cc111d6 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Jun 7, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
b1fea41 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Jun 11, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
f5dff08 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
rmnattas pushed a commit to rmnattas/omr that referenced this issue Jun 14, 2024
@singh264 @JasonFengJ9
@keithc-ca @babsingh @rmnattas
Update the coding standard
9b6a4c1 
Issue: eclipse-openj9/openj9#19261
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Co-authored-by: Babneet Singh <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Jul 17, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
ae65960 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Jul 17, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
5e8c19c 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Jul 18, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
60cd6f2 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9 that referenced this issue Jul 18, 2024
@singh264
Add -XX:CRaCRestoreFrom=PATH tests
ea7261b 
Issue: eclipse-openj9#19261
Depends-on: ibmruntimes/openj9-openjdk-jdk#780
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Jul 29, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
92e54cc 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9 that referenced this issue Jul 29, 2024
@singh264
Add -XX:CRaCRestoreFrom=PATH tests
e440613 
Issue: eclipse-openj9#19261
Depends-on: ibmruntimes/openj9-openjdk-jdk#780
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9 that referenced this issue Jul 29, 2024
@singh264
Add -XX:CRaCRestoreFrom=PATH tests
48aeb92 
Issue: eclipse-openj9#19261
Depends-on: ibmruntimes/openj9-openjdk-jdk#780
Signed-off-by: Amarpreet Singh <[email protected]>
singh264 added a commit to singh264/openj9-openjdk-jdk that referenced this issue Jul 29, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
7218bdb 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
JasonFengJ9 added a commit to JasonFengJ9/openj9-openjdk-jdk that referenced this issue Jul 30, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
620c8a2 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
@singh264
Copy link
Contributor Author

singh264 commented Aug 1, 2024

It seems like the next step is to merge the implementation and test PRs, and backport the implementation to the jdks that support crac.

JasonFengJ9 added a commit to JasonFengJ9/openj9-openjdk-jdk that referenced this issue Aug 7, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
fa1d123 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
JasonFengJ9 added a commit to JasonFengJ9/openj9-openjdk-jdk that referenced this issue Aug 19, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
168d8d1 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
JasonFengJ9 added a commit to JasonFengJ9/openj9-openjdk-jdk that referenced this issue Aug 22, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
b471aeb 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
JasonFengJ9 added a commit to JasonFengJ9/openj9-openjdk-jdk that referenced this issue Sep 17, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
2abf31a 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
JasonFengJ9 added a commit to JasonFengJ9/openj9-openjdk-jdk that referenced this issue Sep 18, 2024
@singh264 @tajila
@JasonFengJ9 @keithc-ca
Support restore with -XX:CRaCRestoreFrom=PATH
5875c62 
Support restore with -XX:CRaCRestoreFrom=PATH that
specifies the path to the checkpoint image.

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Tobi Ajila <[email protected]>
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
JasonFengJ9 pushed a commit to singh264/openj9-openjdk-jdk that referenced this issue Sep 18, 2024
@singh264 @JasonFengJ9
Support restore with -XX:CRaCRestoreFrom=PATH
950c02c 
Support restore with -XX:CRaCRestoreFrom=PATH that specifies the path to
the checkpoint image.

Issue: eclipse-openj9/openj9#19261

Co-authored-by: Amarpreet Singh <[email protected]>
Signed-off-by: Jason Feng <[email protected]>
JasonFengJ9 pushed a commit to JasonFengJ9/openj9-openjdk-jdk11 that referenced this issue Sep 19, 2024
@singh264 @JasonFengJ9
Support restore with -XX:CRaCRestoreFrom=PATH
0a92375 
Support restore with -XX:CRaCRestoreFrom=PATH that specifies the path to
the checkpoint image.

Issue: eclipse-openj9/openj9#19261

Co-authored-by: Amarpreet Singh <[email protected]>
Signed-off-by: Jason Feng <[email protected]>
JasonFengJ9 pushed a commit to JasonFengJ9/openj9-openjdk-jdk17 that referenced this issue Sep 19, 2024
@singh264 @JasonFengJ9
Support restore with -XX:CRaCRestoreFrom=PATH
7056967 
Support restore with -XX:CRaCRestoreFrom=PATH that specifies the path to
the checkpoint image.

Issue: eclipse-openj9/openj9#19261

Co-authored-by: Amarpreet Singh <[email protected]>
Signed-off-by: Jason Feng <[email protected]>
JasonFengJ9 pushed a commit to JasonFengJ9/openj9-openjdk-jdk21 that referenced this issue Sep 19, 2024
@singh264 @JasonFengJ9
Support restore with -XX:CRaCRestoreFrom=PATH
69edef7 
Support restore with -XX:CRaCRestoreFrom=PATH that specifies the path to
the checkpoint image.

Issue: eclipse-openj9/openj9#19261

Co-authored-by: Amarpreet Singh <[email protected]>
Signed-off-by: Jason Feng <[email protected]>
This was referenced Sep 19, 2024
Merged
Merged
Merged
Merged
keithc-ca pushed a commit to ibmruntimes/openj9-openjdk-jdk23 that referenced this issue Sep 23, 2024
@singh264 @JasonFengJ9
Support restore with -XX:CRaCRestoreFrom=PATH
2d37f67 
Support restore with -XX:CRaCRestoreFrom=PATH that specifies the path to
the checkpoint image.

Issue: eclipse-openj9/openj9#19261

Co-authored-by: Amarpreet Singh <[email protected]>
Signed-off-by: Jason Feng <[email protected]>
@pshipton
Copy link
Member

pshipton commented Sep 24, 2024 •
edited
Loading

@JasonFengJ9 Pls create a doc issue.

@tajila
Copy link
Contributor

tajila commented Sep 24, 2024

@JasonFengJ9 Pls create a doc issue.

We havent publicly documented any of the CRaC commands, we've been approaching it piecemeal adding the necessary support for certain usecases.

@tajila tajila closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@singh264 singh264

Labels
criu Used to track CRIU snapshot related work
Projects
None yet
Milestone
Release 0.48 (Java 8, 11, 17, 21, 23)...
Development

No branches or pull requests
3 participants
@tajila @singh264 @pshipton