Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open XL attribute packed and misc fixes #19900

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Deigue
Copy link
Contributor

@Deigue Deigue commented Jul 22, 2024

These changes includes some of the uncategorized fixes, header fixes and the recommended attribute((packed)) notation usage that works with both Open XL and XLC.

@@ -0,0 +1,35 @@
/*******************************************************************************
* Copyright IBM Corp. and others 2012
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this copyright year to be 2024

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, corrected.

Copy link
Contributor

@r30shah r30shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks OK to me, I apart from the copyright, I will launch a sanity build on this one internally before approving.

@Deigue Deigue force-pushed the openxl-fixes-1 branch 2 times, most recently from b6edcfc to 6b1672f Compare July 31, 2024 17:29
@Deigue
Copy link
Contributor Author

Deigue commented Aug 9, 2024

jdk21 build passes

@Deigue
Copy link
Contributor Author

Deigue commented Oct 9, 2024

Rebased with master, java 21 and java 8 builds passing. @r30shah this one is ready to merge/review.

Copy link
Contributor

@r30shah r30shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Deigue Can you launch IBM SDK 8 build internally on all platforms for sanity?

@Deigue
Copy link
Contributor Author

Deigue commented Dec 5, 2024

Rebased to latest master, and launched j8 sanity all internally to verify.

@r30shah
Copy link
Contributor

r30shah commented Dec 5, 2024

Jenkins test sanity all jdk11,jdk21

@r30shah
Copy link
Contributor

r30shah commented Dec 6, 2024

@Deigue Can you check if the failure seen in the tests are related or not?

@r30shah
Copy link
Contributor

r30shah commented Dec 6, 2024

S390x Failure seems to be same as #14948 - Not related to this PR

@r30shah
Copy link
Contributor

r30shah commented Dec 6, 2024

Jenkins test sanity x86-64_windows jdk11,jdk21

@r30shah
Copy link
Contributor

r30shah commented Dec 6, 2024

Relaunched Windows build as it failed because none of the build machine was online.

@Deigue We need to confirm if PPC failures are related or not. 10x grinder did pass : https://openj9-jenkins.osuosl.org/job/Grinder/4015/console

These changes includes some of the uncategorized fixes,
header fixes and the recommended __attribute__((packed))
notation usage that works with both Open XL and XLC.

Signed-off-by: Gaurav Chaudhari <[email protected]>
@r30shah
Copy link
Contributor

r30shah commented Jan 20, 2025

Jenkins test sanity all jdk11,jdk21

1 similar comment
@r30shah
Copy link
Contributor

r30shah commented Feb 7, 2025

Jenkins test sanity all jdk11,jdk21

@r30shah
Copy link
Contributor

r30shah commented Feb 11, 2025

Jenkins test sanity zlinux,xlinux jdk11

@r30shah
Copy link
Contributor

r30shah commented Feb 12, 2025

Jenkins test sanity zlinux,xlinux jdk21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants