-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open XL attribute packed and misc fixes #19900
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,35 @@ | |||
/******************************************************************************* | |||
* Copyright IBM Corp. and others 2012 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this copyright year to be 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, corrected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks OK to me, I apart from the copyright, I will launch a sanity build on this one internally before approving.
b6edcfc
to
6b1672f
Compare
jdk21 build passes |
Rebased with master, java 21 and java 8 builds passing. @r30shah this one is ready to merge/review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @Deigue Can you launch IBM SDK 8 build internally on all platforms for sanity?
1f9f298
to
e4a5f57
Compare
Rebased to latest master, and launched j8 sanity all internally to verify. |
Jenkins test sanity all jdk11,jdk21 |
@Deigue Can you check if the failure seen in the tests are related or not? |
S390x Failure seems to be same as #14948 - Not related to this PR |
Jenkins test sanity x86-64_windows jdk11,jdk21 |
Relaunched Windows build as it failed because none of the build machine was online. @Deigue We need to confirm if PPC failures are related or not. 10x grinder did pass : https://openj9-jenkins.osuosl.org/job/Grinder/4015/console |
These changes includes some of the uncategorized fixes, header fixes and the recommended __attribute__((packed)) notation usage that works with both Open XL and XLC. Signed-off-by: Gaurav Chaudhari <[email protected]>
e4a5f57
to
e5dd13b
Compare
Jenkins test sanity all jdk11,jdk21 |
1 similar comment
Jenkins test sanity all jdk11,jdk21 |
Jenkins test sanity zlinux,xlinux jdk11 |
Jenkins test sanity zlinux,xlinux jdk21 |
These changes includes some of the uncategorized fixes, header fixes and the recommended attribute((packed)) notation usage that works with both Open XL and XLC.