Unexpected trace option processing with none and multiple components

[pshipton]

The option -Xtrace:none,maximal={omrport.220-223,j9jcl.156-161},output=shared%p.trc gets parsed as the following, which isn't what is expected.

-Xtrace:none,maximal=omrport.220-223,output=shared%p.trc
-Xtrace:none,maximal=j9jcl.156-161,output=shared%p.trc

The expected behavior requires -Xtrace:none -Xtrace:maximal={omrport.220-223,j9jcl.156-161},output=shared%p.trc

Not sure if this is by design. It seems the -Xtrace option builder should be updated to specify none as a separate option.
https://eclipse.dev/openj9/tools/xtrace_option_builder.html

Also, the list of trace components in the tool isn't complete, i.e. it doesn't include omrport, or any other omr trace components (omrutil, omrvm, omrti, omrmm - see OMRTraceFormat.dat).
@keithc-ca @paulcheeseman

[paulcheeseman]

@pshipton

It seems the -Xtrace option builder should be updated to specify none as a separate option.

This wouldn't be a trivial change - the tool is very much built around the generation of a single option. The behaviour you describe (i.e. the JVM expanding the single option into two options, and none being specified in both) seems like a bug to me.

Also, the list of trace components in the tool isn't complete, i.e. it doesn't include omrport, or any other omr trace components (omrutil, omrvm, omrti, omrmm - see OMRTraceFormat.dat).

This can certainly be fixed.

[paulcheeseman]

@pshipton

Also, the list of trace components in the tool isn't complete, i.e. it doesn't include omrport, or any other omr trace components (omrutil, omrvm, omrti, omrmm - see OMRTraceFormat.dat).

The list of tracepoint components in the Xtrace Option Builder is based on the list provided here:

https://eclipse.dev/openj9/docs/xtrace/#tracepoint-specification

If that list can be brought up to date I will include the new components in the tool.

In addition to the missing OMR components, there are a number of components in J9TraceFormat.dat which look like they might need to be added too:

• cuda4j
• hashtable
• j9hshelp
• j9thr
• j9trc_aux
• j9utilcore
• j9vmchk
• map
• module
• simplepool
• srphashtable

[pshipton]

Created eclipse-openj9/openj9-docs#1413

[paulcheeseman]

Created eclipse-openj9/openj9-website-publish#19

[pshipton]

@paulcheeseman there were more changes to eclipse-openj9/openj9-docs#1413 to add many more missing groups.