Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdk24 java.lang.AssertionError: sun.security.util.ResourcesMgr (PD) #20351

Closed
pshipton opened this issue Oct 15, 2024 · 4 comments · Fixed by #21073 or #21077
Closed

jdk24 java.lang.AssertionError: sun.security.util.ResourcesMgr (PD) #20351

pshipton opened this issue Oct 15, 2024 · 4 comments · Fixed by #21073 or #21077
Assignees
@babsingh
Labels
comp:vm jdk24 project:MH Used to track Method Handles related work test failure
Milestone
Java 24 (0.50)

Comments

@pshipton
Copy link
Member

https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.openjdk_aarch64_mac_Personal_testList_0/6
jdk_lang
java/lang/Class/ProtectionDomainRace.java

14:43:27  java.lang.AssertionError: sun.security.util.ResourcesMgr (PD)
14:43:27  	at java.base/java.lang.invoke.MethodHandleImpl$BindCaller.checkInjectedInvoker(MethodHandleImpl.java:1219)
14:43:27  	at java.base/java.lang.invoke.MethodHandleImpl$BindCaller.makeInjectedInvoker(MethodHandleImpl.java:1120)
14:43:27  	at java.base/java.lang.invoke.MethodHandleImpl$BindCaller$1.computeValue(MethodHandleImpl.java:1127)
14:43:27  	at java.base/java.lang.invoke.MethodHandleImpl$BindCaller$1.computeValue(MethodHandleImpl.java:1124)
14:43:27  	at java.base/java.lang.ClassValue.getFromHashMap(ClassValue.java:235)
14:43:27  	at java.base/java.lang.ClassValue.getFromBackup(ClassValue.java:217)
14:43:27  	at java.base/java.lang.ClassValue.get(ClassValue.java:123)
14:43:27  	at java.base/java.lang.invoke.MethodHandleImpl$BindCaller.bindCallerWithInjectedInvoker(MethodHandleImpl.java:1099)
14:43:27  	at java.base/java.lang.invoke.MethodHandleImpl$BindCaller.bindCaller(MethodHandleImpl.java:1087)
14:43:27  	at java.base/java.lang.invoke.MethodHandleImpl.bindCaller(MethodHandleImpl.java:1040)
14:43:27  	at java.base/java.lang.invoke.MethodHandles$Lookup.maybeBindCaller(MethodHandles.java:4134)
14:43:27  	at java.base/java.lang.invoke.MethodHandles$Lookup.getDirectMethodCommon(MethodHandles.java:4118)
14:43:27  	at java.base/java.lang.invoke.MethodHandles$Lookup.getDirectMethodNoSecurityManager(MethodHandles.java:4062)
14:43:27  	at java.base/java.lang.invoke.MethodHandles$Lookup.getDirectMethodForConstant(MethodHandles.java:4311)
14:43:27  	at java.base/java.lang.invoke.MethodHandles$Lookup.linkMethodHandleConstant(MethodHandles.java:4259)
14:43:27  	at java.base/java.lang.invoke.MethodHandleNatives.linkMethodHandleConstant(MethodHandleNatives.java:634)
14:43:27  	at java.base/java.lang.invoke.MethodHandleResolver.sendResolveMethodHandle(MethodHandleResolver.java:297)
14:43:27  	at java.base/java.lang.invoke.MethodHandleResolver.getCPMethodHandleAt(Native Method)
14:43:27  	at java.base/java.lang.invoke.MethodHandleResolver.getAdditionalBsmArg(MethodHandleResolver.java:412)
14:43:27  	at java.base/java.lang.invoke.MethodHandleResolver.resolveInvokeDynamic(MethodHandleResolver.java:186)
14:43:27  	at java.base/sun.security.util.ResourcesMgr.getBundle(ResourcesMgr.java:54)
14:43:27  	at java.base/sun.security.util.ResourcesMgr.getString(ResourcesMgr.java:40)
14:43:27  	at java.base/javax.security.auth.Subject.doAs(Subject.java:517)
14:43:27  	at ProtectionDomainRace.lambda$main$1(ProtectionDomainRace.java:66)
14:43:27  	at java.base/java.lang.Thread.run(Thread.java:1588)
@pshipton pshipton added this to the Java 24 milestone Oct 15, 2024
@github-actions GitHub Actions
Copy link

Issue Number: 20351
Status: Open
Recommended Components: comp:vm, comp:jclextensions, comp:gc
Recommended Assignees: babsingh, jasonfengj9, fengxue-is

@babsingh babsingh mentioned this issue Nov 7, 2024
Merged
@pshipton pshipton mentioned this issue Jan 16, 2025
Closed
@babsingh babsingh self-assigned this Jan 21, 2025
@babsingh babsingh added the project:MH Used to track Method Handles related work label Jan 21, 2025
@keithc-ca keithc-ca mentioned this issue Jan 27, 2025
Merged
@pshipton
Copy link
Member Author

pshipton commented Jan 28, 2025 •
edited
Loading

https://openj9-jenkins.osuosl.org/job/Test_openjdk24_j9_sanity.openjdk_s390x_linux_Nightly_testList_0/3/
https://openj9-jenkins.osuosl.org/job/Test_openjdk24_j9_sanity.openjdk_x86-64_mac_Nightly_testList_1/3/
https://openj9-jenkins.osuosl.org/job/Test_openjdk24_j9_sanity.openjdk_x86-64_linux_Nightly_testList_1/3/

pshipton added a commit to pshipton/openjdk-tests that referenced this issue Jan 28, 2025
@pshipton
Temporarily exclude java/lang/Class/ProtectionDomainRace on jdk24 OpenJ9
f54ac74 
Issue eclipse-openj9/openj9#20351

Signed-off-by: Peter Shipton <[email protected]>
@pshipton pshipton mentioned this issue Jan 28, 2025
Merged
@pshipton
Copy link
Member Author

Temporarily exclude it via adoptium/aqa-tests#5922

llxia pushed a commit to adoptium/aqa-tests that referenced this issue Jan 28, 2025
@pshipton
Temporarily exclude java/lang/Class/ProtectionDomainRace on jdk24 Ope…
154fd4c 
…nJ9 (#5922)

Issue eclipse-openj9/openj9#20351

Signed-off-by: Peter Shipton <[email protected]>
@babsingh babsingh mentioned this issue Feb 5, 2025
Merged
@keithc-ca
Copy link
Contributor

This problem can still occur; see #21073 (review).

@keithc-ca keithc-ca reopened this Feb 6, 2025
babsingh added a commit to babsingh/openj9 that referenced this issue Feb 6, 2025
@babsingh
Use a static synchronized method for allPermissionsPD
5464248 
Since allPermissionsPD is a static field, a static synchronized
method locks on Class.class, which is the correct approach.

Fixes: eclipse-openj9#20351

Signed-off-by: Babneet Singh <[email protected]>
babsingh added a commit to babsingh/openj9 that referenced this issue Feb 6, 2025
@babsingh
Use a static synchronized method for allPermissionsPD
1bbe3b3 
Since allPermissionsPD is a static field, a static synchronized
method locks on Class.class, which is the correct approach.

Fixes: eclipse-openj9#20351

Signed-off-by: Babneet Singh <[email protected]>
babsingh added a commit to babsingh/openj9 that referenced this issue Feb 6, 2025
@babsingh
Use a static synchronized method for allPermissionsPD
bc98382 
Since allPermissionsPD is a static field, a static synchronized
method locks on Class.class, which is the correct approach for
ensuring thread safety.

Fixes: eclipse-openj9#20351

Signed-off-by: Babneet Singh <[email protected]>
@babsingh babsingh mentioned this issue Feb 6, 2025
Merged
babsingh added a commit to babsingh/openj9 that referenced this issue Feb 6, 2025
@babsingh
Use a nested holder class to store allPermissionsPD
cc5ef2f 
Using this approach, allPermissionsPD can be a final field. VM's class
initialization mechanisms will prevent races via the static block.

Fixes: eclipse-openj9#20351

Signed-off-by: Babneet Singh <[email protected]>
babsingh added a commit to babsingh/openj9 that referenced this issue Feb 6, 2025
@babsingh
Use a nested holder class to store allPermissionsPD
e51a32e 
Using this approach, allPermissionsPD can be a final field. VM's class
initialization mechanisms will prevent races via the static block.

Fixes: eclipse-openj9#20351

Signed-off-by: Babneet Singh <[email protected]>
babsingh added a commit to babsingh/openj9 that referenced this issue Feb 6, 2025
@babsingh
Use a nested holder class to store allPermissionsPD
2182298 
Using this approach, allPermissionsPD can be a final field. VM's class
initialization mechanisms will prevent races via the static block.

Fixes: eclipse-openj9#20351

Signed-off-by: Babneet Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@babsingh babsingh

Labels
comp:vm jdk24 project:MH Used to track Method Handles related work test failure
Projects
None yet
Milestone
Java 24 (0.50)
3 participants
@babsingh @keithc-ca @pshipton