Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x86: Respect disableAVX2/512 options and check XCR0 for OS support #20691

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

x86: Respect disableAVX2/512 options and check XCR0 for OS support #20691

wants to merge 2 commits into from

Conversation

BradleyWood
Copy link
Member

@BradleyWood BradleyWood commented Nov 27, 2024 •
edited
Loading

@BradleyWood BradleyWood added depends:omr Pull request is dependent on a corresponding change in OMR comp:jit arch:x86 labels Nov 27, 2024
@BradleyWood BradleyWood force-pushed the disablecpufeature branch 3 times, most recently from ba7cf9a to 7271349 Compare December 6, 2024 17:38
@BradleyWood BradleyWood changed the title x86: use OMR option to disable CPU features x86: Respect disableAVX2/512 options and check XCR0 for OS support Dec 6, 2024
@BradleyWood BradleyWood mentioned this pull request Dec 6, 2024
Merged
@BradleyWood BradleyWood marked this pull request as ready for review December 11, 2024 01:31
@BradleyWood BradleyWood requested a review from dsouzai as a code owner December 11, 2024 01:31
0xdaryl
0xdaryl reviewed Jan 20, 2025
View reviewed changes
runtime/compiler/env/ProcessorDetection.cpp Outdated Show resolved Hide resolved
runtime/compiler/x/env/J9CPU.cpp Outdated Show resolved Hide resolved
@BradleyWood
Copy link
Member Author

@0xdaryl See the force-push

@0xdaryl
Copy link
Contributor

0xdaryl commented Jan 23, 2025

Jenkins test sanity xlinux,win,osx jdk21

@0xdaryl
Copy link
Contributor

0xdaryl commented Jan 24, 2025

Windows nodes are offline. As this PR does have a Windows-specific component to it, can you confirm it's been built and tested on Windows?

@BradleyWood
Copy link
Member Author

@0xdaryl can you relaunch?

@0xdaryl
Copy link
Contributor

0xdaryl commented Jan 28, 2025

Jenkins test sanity.functional,sanity.openjdk win jdk21

@0xdaryl
Copy link
Contributor

0xdaryl commented Feb 4, 2025

Just a ping on triaging the Windows CI failures.

@BradleyWood
Copy link
Member Author

I don't think any of the windows tests ran. The only obvious error I see is this:

[2025-01-28T19:51:24.425Z] /bin/sh: -c: line 3: syntax error: unexpected end of file
[2025-01-28T19:51:24.425Z] make[2]: *** [settings.mk:383: setup_testList] Error 1

@0xdaryl
Copy link
Contributor

0xdaryl commented Feb 4, 2025

Jenkins test sanity.functional,sanity.openjdk win jdk21

@0xdaryl
Copy link
Contributor

0xdaryl commented Feb 5, 2025

I sniffed at the CI failures and see at least one JVM crash with an illegal instruction exception:

https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.openjdk_x86-64_windows_Personal_testList_1/65/consoleFull

@BradleyWood
Copy link
Member Author

Probably issue #21000? All the crashes happen in byte array hashcode with -XX:-UseCompressedOops. I will try to confirm soon...

@0xdaryl
Copy link
Contributor

0xdaryl commented Feb 7, 2025

I will try to confirm soon...
Have you confirmed that all the failures are known issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdaryl 0xdaryl 0xdaryl left review comments

@dsouzai dsouzai Awaiting requested review from dsouzai dsouzai is a code owner

Assignees

@0xdaryl 0xdaryl

Labels
arch:x86 comp:jit depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BradleyWood @0xdaryl