Use a nested holder class to store allPermissionsPD #21077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
force-pushed
the
main13
branch
2 times, most recently
from
cc5ef2f to
e51a32e
Compare
babsingh
changed the title
|
@keithc-ca Have I implemented your suggestion in #21073 (comment) correctly? |
keithc-ca
requested changes
Feb 6, 2025
Using this approach, allPermissionsPD can be a final field. VM's class initialization mechanisms will prevent races via the static block. Fixes: eclipse-openj9#20351 Signed-off-by: Babneet Singh <[email protected]>
keithc-ca
approved these changes
Feb 6, 2025
|
Jenkins compile amac jdk21 |
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Feb 6, 2025
ProtectionDomainRace has been fixed by eclipse-openj9/openj9#21077 Signed-off-by: Babneet Singh <[email protected]>
llxia
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Feb 6, 2025
ProtectionDomainRace has been fixed by eclipse-openj9/openj9#21077 Signed-off-by: Babneet Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this approach,
allPermissionsPDcan be a final field. VM's classinitialization mechanisms will prevent races via the
staticblock.Fixes: #20351