Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object model API for minimum object size in bytes #21079

Closed
wants to merge 1 commit into from

Conversation

VermaSh
Copy link
Contributor

@VermaSh VermaSh commented Feb 6, 2025

No description provided.

@VermaSh
Copy link
Contributor Author

VermaSh commented Feb 6, 2025

@dmitripivkine Can I please I get an initial review for this?

@dmitripivkine
Copy link
Contributor

@dmitripivkine Can I please I get an initial review for this?

Well, you need JIT reviewer obviously. The usage of external GC function is correct.

@VermaSh VermaSh force-pushed the addMinimumSizeAPI branch 3 times, most recently from 7f7d37c to 6596e19 Compare February 6, 2025 19:56
@VermaSh
Copy link
Contributor Author

VermaSh commented Feb 7, 2025

Local testing looks good, removing WIP tag. @r30shah can I please get a review for this?

@VermaSh VermaSh marked this pull request as ready for review February 7, 2025 16:20
@VermaSh VermaSh requested a review from dsouzai as a code owner February 7, 2025 16:20
@VermaSh VermaSh changed the title WIP: Add object model API for minimum object size in bytes Add object model API for minimum object size in bytes Feb 7, 2025
Copy link
Contributor

@r30shah r30shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add brief information about this API in the commit body. Changes looks good to me. Once you make the change, I will start the tests.

@VermaSh
Copy link
Contributor Author

VermaSh commented Feb 12, 2025

@r30shah Just found out that we can use J9_GC_MINIMUM_OBJECT_SIZE to get minimum object size so we don't need this change. Closing the PR.

@VermaSh VermaSh closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants