Skip to content

Commit 515f996

Browse files
iloveeclipseHannesWell
authored andcommitted
Don't apply empty settings from not initialized TracingBlock
Fixes #1621
1 parent 79d7e75 commit 515f996

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/launcher/TracingBlock.java

+7
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ private Map<String, String> runShowingProgress(
122122
private final Map<IPluginModelBase, TracingPropertySource> fPropertySources = new HashMap<>();
123123
private FormToolkit fToolkit;
124124
private ScrolledPageBook fPageBook;
125+
private boolean activated;
125126

126127
/**
127128
* The last selected item in the list is stored in the dialog settings.
@@ -351,6 +352,7 @@ private void activateInternal(ILaunchConfiguration config) {
351352
pluginSelected(null, false);
352353
}
353354
}
355+
activated = true;
354356
} catch (CoreException e) {
355357
PDEPlugin.logException(e);
356358
}
@@ -361,6 +363,11 @@ public void setRunnableContext(IRunnableContext runnableContext) {
361363
}
362364

363365
public void performApply(ILaunchConfigurationWorkingCopy config) {
366+
if (!activated) {
367+
// nothing to apply as we weren't initialized before,
368+
// all the data is empty anyway
369+
return;
370+
}
364371
boolean tracingEnabled = fTracingCheck.getSelection();
365372
config.setAttribute(IPDELauncherConstants.TRACING, tracingEnabled);
366373
if (tracingEnabled) {

0 commit comments

Comments
 (0)