Skip to content

Commit d9768bf

Browse files
committed
Skip the method PluginsTab::performApply until after activation
If this method (or part of it) is run before the tab has been activated then the default configuration passed as parameter will be modified and incorrect values will be introduced. This commit fixes a regression introduced in 98a5865 Fixes #1250
1 parent 65942e1 commit d9768bf

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/launcher/PluginsTab.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -199,12 +199,13 @@ public void setDefaults(ILaunchConfigurationWorkingCopy configuration) {
199199

200200
@Override
201201
public void performApply(ILaunchConfigurationWorkingCopy configuration) {
202+
if (!fActivated) {
203+
return;
204+
}
202205
int index = fSelectionCombo.getSelectionIndex();
203206
configuration.setAttribute(IPDELauncherConstants.USE_DEFAULT, index == DEFAULT_SELECTION);
204207
configuration.setAttribute(IPDELauncherConstants.USE_CUSTOM_FEATURES, index == FEATURE_SELECTION);
205-
if (fActivated) {
206208
fBlock.performApply(configuration);
207-
}
208209
// clear default values for auto-start and start-level if default
209210
String autoText = fDefaultAutoStart.getText();
210211
if (Boolean.toString(false).equals(autoText)) {

0 commit comments

Comments
 (0)