Suppress resolution if 'Configure problem severity' is the only available options

[nburnwal09]

Currently, the context menu option "Quick fix" is visible for problems where no fix is available, which then leads to a pop-up menu saying No fixes available.
There are many such issues for this condition. Attaching a sample here for the issue - a space added after the header name before the ':'.

Steps to reproduce:

1. Introduce a minor issue in the code, such as adding an extra space after the header name before the ':'.
2. Right-click on the problem in the Problems view.
3. Select the "Quick fix" context menu option.
4. Observe the pop-up menu indicating 'No fixes available.'

This behaviour misleads developers into thinking that a quick fix is available for the problem. After clicking the 'Quick fix' context menu option, it states 'No fixes available,' which can waste developers' time and cause frustration.

To avoid this misleading, one solution could be to disable the context menu option 'Quick fix' where no fixes are available like this:

[laeubi]

The QuickFix menu is provided by platform, not by PDE. Beside that the main problem is that computing Quickfixes can be an expensive task so disable the menu item might not be possible without performance issues when opening the menu.

[nburnwal09]

Upon right click on the problem to get the context menu pop-up, the code passes through this function in PDE (before the context menu pop-up is showed)

eclipse.pde/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/correction/ResolutionGenerator.java

Lines 159 to 165 in 975f72b

	int getProblemId(IMarker marker) {
	int problemID = marker.getAttribute(PDEMarkerFactory.PROBLEM_ID, PDEMarkerFactory.NO_RESOLUTION);
	if (problemID != PDEMarkerFactory.NO_RESOLUTION) {
	return problemID;
	}
	return marker.getAttribute("id", PDEMarkerFactory.NO_RESOLUTION); //$NON-NLS-1$
	}

via function hasResolution

eclipse.pde/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/correction/ResolutionGenerator.java

Lines 257 to 259 in 975f72b

	public boolean hasResolutions(IMarker marker) {
	return getProblemId(marker) > 0;
	}

And in cases where it reaches to Line 164, where marker id is getting set with PDEMarkerFactory.NO_RESOLUTION, the Quick fix menu option gets disabled today as well. We just would have to work around similar way for other no quick fix available problems as well.

[laeubi]

Then the title of the issue is misleading. PDE itself can't disable the menu, but it should report proper boolean hasResolutions(IMarker marker) for some of its problems.

[nburnwal09]

Yes, I agree. The underlying problem is that there are several markers where the problemID has the value PDEMarkerFactory.M_ONLY_CONFIG_SEV as the resolution, i.e., the "Configure problem severity" option only.
Instead of showing this in the quick fix dialog, the current implementation displays 'No quick fixes available.'

eclipse.pde/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/correction/ResolutionGenerator.java

Line 55 in 975f72b

public IMarkerResolution[] getNonConfigSevResolutions(IMarker marker) {

eclipse.pde/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/correction/ResolutionGenerator.java

Lines 146 to 151 in 975f72b

	case PDEMarkerFactory.M_CONFLICTING_AUTOMATIC_MODULE:
	return new IMarkerResolution[] {
	new RemoveRedundantAutomaticModuleHeader(AbstractPDEMarkerResolution.REMOVE_TYPE, marker) };
	}
	return NO_RESOLUTIONS;
	}

To avoid misleading the user, one solution could be to return PDEMarkerFactory.NO_RESOLUTION for all such cases where the marker problemID only has PDEMarkerFactory.M_ONLY_CONFIG_SEV as the resolution.

In the future, we could implement an option to show 'Configure problem severity' along with the correct quick fix implementation.