Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for ui/org.eclipse.pde.genericeditor.extension #1654

Merged

Conversation

eclipse-pde-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

@eclipse-pde-bot
Copy link
Contributor Author

eclipse-pde-bot commented Mar 6, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From ee16169ff6ed7f91ae5473477471949ebaf505fb Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Fri, 7 Mar 2025 03:08:25 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF
index dbc617757c..26891db600 100644
--- a/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.genericeditor.extension;singleton:=true
-Bundle-Version: 1.3.0.qualifier
+Bundle-Version: 1.3.100.qualifier
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.jface.text,
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

github-actions bot commented Mar 6, 2025

Test Results

   279 files   -   6     279 suites   - 6   45m 44s ⏱️ - 1m 17s
 3 608 tests ±  0   3 530 ✅  -   1   77 💤 + 1  1 ❌ ±0 
10 822 runs   - 194  10 618 ✅  - 166  203 💤  - 28  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 81cc781. ± Comparison against base commit 4e00417.

This pull request skips 1 test.
org.eclipse.pde.build.internal.tests.p2.P2Tests ‑ offBug237662

♻️ This comment has been updated with latest results.

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ui/org.eclipse.pde.genericeditor.extension branch from e4b9e39 to b1813cf Compare March 7, 2025 03:01
@laeubi laeubi merged commit 81c26d5 into master Mar 7, 2025
16 of 18 checks passed
@akurtakov akurtakov deleted the clean-code/ui/org.eclipse.pde.genericeditor.extension branch March 7, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants