Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for ui/org.eclipse.pde.ui.templates #1661

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

eclipse-pde-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

@eclipse-pde-bot
Copy link
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.ui.templates/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From f33153fa485de784e3319e8edb485e567625886e Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Thu, 6 Mar 2025 03:29:28 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ui/org.eclipse.pde.ui.templates/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.ui.templates/META-INF/MANIFEST.MF
index bf7525dc33..5259803ad6 100644
--- a/ui/org.eclipse.pde.ui.templates/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.ui.templates/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %bundleName
 Bundle-SymbolicName: org.eclipse.pde.ui.templates;singleton:=true
-Bundle-Version: 3.9.0.qualifier
+Bundle-Version: 3.9.100.qualifier
 Bundle-Vendor: %bundleVendor
 Bundle-RequiredExecutionEnvironment: JavaSE-21
 Export-Package: org.eclipse.pde.internal.ui.templates;x-internal:=true,
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

github-actions bot commented Mar 6, 2025

Test Results

   285 files  ±0     285 suites  ±0   47m 17s ⏱️ - 1m 56s
 3 608 tests ±0   3 532 ✅ ±0   76 💤 ±0  0 ❌ ±0 
11 016 runs  ±0  10 785 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit 896ca91. ± Comparison against base commit 966b668.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the clean-code/ui/org.eclipse.pde.ui.templates branch from c7c32f3 to 896ca91 Compare March 6, 2025 15:00
@laeubi laeubi merged commit 7691121 into master Mar 6, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/ui/org.eclipse.pde.ui.templates branch March 6, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants