You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Browser tests: reduce timeout for instantiation to reasonable value
The timeout for browser instantiation in the browser tests has been
increased to avoid flaky tests. However, browser instantiation taking
more than 10 seconds (the previous timeout value) is an indicator for
something being wrong with the instantiation. There is no reason why
instantiation may take that long during test execution but the same
issue should never arise in productive use, thus such a case should be
captured by tests and, if necessary, be fixed productively.
In order to do so, this change reduces the test timeout value again to a
more reasonable value.
Related to
#1676
Copy file name to clipboardExpand all lines: tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java
+2-2
Original file line number
Diff line number
Diff line change
@@ -163,7 +163,7 @@ public static void setupEdgeEnvironment() {
163
163
// initialize Edge environment before any test runs to isolate environment setup
164
164
if (SwtTestUtil.isWindows) {
165
165
Shellshell = newShell();
166
-
newBrowser(shell, SWT.EDGE);
166
+
newBrowser(shell, SWT.EDGE).getUrl();
167
167
shell.dispose();
168
168
}
169
169
}
@@ -302,7 +302,7 @@ private int reportOpenedDescriptors() {
302
302
}
303
303
304
304
privateBrowsercreateBrowser(Shells, intflags) {
305
-
longmaximumBrowserCreationMilliseconds = 90_000;
305
+
longmaximumBrowserCreationMilliseconds = 15_000;
306
306
longcreateStartTime = System.currentTimeMillis();
307
307
Browserb = newBrowser(s, flags);
308
308
// Wait for asynchronous initialization via getting URL
0 commit comments