Commit 7625606
committed
[Edge] Cancel the timer from running when we are done with it
Each use of a timer creates a User Object in Windows, and once we
have stopped waiting for our desired event we don't need the cancellation
tracking anymore.
If there are lots of calls to processOSMessagesUntil, such as repeated
browser.setText within the MAXIMUM_OPERATION_TIME (5 second) window,
we can end up with a huge growth in the number of User Objects, leading
to potential `SWTError: No more handles` errors elsewhere in the client
code.
Fixes #28061 parent 28bb9b4 commit 7625606
File tree
1 file changed
+3
-1
lines changed- bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser
1 file changed
+3
-1
lines changedLines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
551 | 551 | | |
552 | 552 | | |
553 | 553 | | |
554 | | - | |
| 554 | + | |
| 555 | + | |
555 | 556 | | |
556 | 557 | | |
557 | 558 | | |
558 | 559 | | |
559 | 560 | | |
560 | 561 | | |
561 | 562 | | |
| 563 | + | |
562 | 564 | | |
563 | 565 | | |
564 | 566 | | |
| |||
0 commit comments