Skip to content

Commit efc9097

Browse files
committed
Exclude TODO tests by default, include them with runtodotests label
In #2757 the idea of using `@Tag("gtk4-todo")` was introduced to tag tests that are known TODO as such. This commit adds todos to the exclude groups list when running such tests. There are not actually any GTK3 x11 todos yet, so this commit on its own may not make sense until GTK4 + wayland tests are enabled in a subsequent commit Apply the label runtodotests to the PR and the todo tests will not be excluded. Part of #2714
1 parent 644bb90 commit efc9097

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

.github/workflows/build.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ on:
2323
type: boolean
2424
required: false
2525
default: false
26+
runtodotests:
27+
description: "Run TODO tagged tests too (one of true, false)"
28+
type: boolean
29+
required: false
30+
default: false
2631

2732
jobs:
2833
build:
@@ -66,6 +71,7 @@ jobs:
6671
--fail-at-end
6772
-DskipNativeTests=false
6873
-DfailIfNoTests=false
74+
${{ (inputs.runtodotests == false && contains(inputs.native, 'linux')) && '-DexcludedGroups=gtk3-todo' || '' }}
6975
clean install
7076
- name: Performance tests
7177
if: ${{ inputs.performance }}

.github/workflows/maven.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ jobs:
9494
java: ${{ matrix.java }}
9595
native: gtk.linux.x86_64
9696
performance: ${{ contains(github.event.pull_request.labels.*.name, 'performance') }}
97+
runtodotests: ${{ contains(github.event.pull_request.labels.*.name, 'runtodotests') }}
9798

9899
build-windows:
99100
name: Build (Windows)
@@ -110,6 +111,7 @@ jobs:
110111
java: ${{ matrix.java }}
111112
native: win32.win32.x86_64
112113
performance: ${{ contains(github.event.pull_request.labels.*.name, 'performance') }}
114+
runtodotests: ${{ contains(github.event.pull_request.labels.*.name, 'runtodotests') }}
113115

114116
build-macos:
115117
name: Build (macOS)
@@ -133,3 +135,4 @@ jobs:
133135
java: ${{ matrix.java }}
134136
native: ${{ matrix.native }}
135137
performance: ${{ contains(github.event.pull_request.labels.*.name, 'performance') }}
138+
runtodotests: ${{ contains(github.event.pull_request.labels.*.name, 'runtodotests') }}

0 commit comments

Comments
 (0)