Edge: Roadmap to making edge the default browser on Windows #1466

sratz · 2024-09-12T09:08:33Z

Background

The Internet Explorer engine on Windows is still the default engine to date.
This engine however is heavily out-of-date and does not support the latest HTML/JS features imperative for modern developments.

The Edge implementation is available via SWT.EDGE flag or via -Dorg.eclipse.swt.browser.DefaultType=edge vm arg.

Goal

The goal should be to make the Edge implementation the default browser engine on Windows.

Proposal

Use this (umbrella) issue to keep track of open issues and to categorize them by severity
Once we have a stable enough state with no blockers, test-drive the Edge implementation by temporarily making it the default in the Platform I-Builds.
Based on this test drive:
- Collect more bugs and issues
- Revert back to IE, if critical

Issues

Edge related Issues / PRs: edge Edge Browser

Blocker / Major

Minor

Uncategorized

PDE

Browser View templates should use SWT.DEFAULT as browser style eclipse-pde/eclipse.pde#1509

Out-of-scope (e.g. Edge-specific API)

Browser-agnostic feature requests

API to clear internal browser cache #283

The text was updated successfully, but these errors were encountered:

…1466 - Introduce SWT flag SWT.IE to be used for Browser to create an Internet Explorer instance - Adapt mapping of existing VM argument for default browser to map "ie" to new Internet Explorer flag and use Edge as default - Make SWT Browser instantiate Edge on Windows by default, i.e., unless the flag SWT.IE is specified - Adapt the SWT ControlExample to represent the SWT.IE flag and properly switch between Edge, Internet Explorer and default - Adapt Browser tests to consider to new default configuration Contributes to eclipse-platform#1466

- Introduce SWT flag SWT.IE to be used for Browser to create an Internet Explorer instance - Adapt mapping of existing VM argument for default browser to map "ie" to new Internet Explorer flag and use Edge as default - Make SWT Browser instantiate Edge on Windows by default, i.e., unless the flag SWT.IE is specified - Adapt the SWT ControlExample to represent the SWT.IE flag and properly switch between Edge, Internet Explorer and default - Adapt Browser tests to consider to new default configuration Contributes to #1466

This commit encapsulates the ICoreWeICoreWebView2*::Release call for all the ICoreWebView2* instances in WebViewWrapper into a method WebViewWrapper::releaseWebViews for a better encapsulation which can be used to dispose off the created ICoreWebView2* resources. contributes to eclipse-platform#1466

This commit conributes to handle how webViewWrapperFuture should exceptionally complete if there happens an edge operation timeout in processOSMessagesUntil method contributes to eclipse-platform#1466 and eclipse.platform.ui/#2734

This commit encapsulates the ICoreWeICoreWebView2*::Release call for all the ICoreWebView2* instances in WebViewWrapper into a method WebViewWrapper::releaseWebViews for a better encapsulation which can be used to dispose off the created ICoreWebView2* resources. contributes to eclipse-platform#1466

This commit conributes to handle how webViewWrapperFuture should exceptionally complete if there happens an edge operation timeout in processOSMessagesUntil method contributes to eclipse-platform#1466 and eclipse.platform.ui/#2734 # Conflicts: # bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser/Edge.java

This commit encapsulates the ICoreWeICoreWebView2*::Release call for all the ICoreWebView2* instances in WebViewWrapper into a method WebViewWrapper::releaseWebViews for a better encapsulation which can be used to dispose off the created ICoreWebView2* resources. contributes to eclipse-platform#1466

This commit conributes to handle how webViewWrapperFuture should exceptionally complete if there happens an edge operation timeout in processOSMessagesUntil method contributes to eclipse-platform#1466 and eclipse.platform.ui/#2734

HeikoKlare · 2025-03-21T07:47:18Z

I see a delay between my dialog showing with the Browser component and the text appearing. Also a very short text shows the same delay.. like "HELLO". If I use the SWT.IE flag, the delay is gone. Can something be done to remove that delay?

Can you say something about how long/severe that delay is? I can actually not reproduce it.
Anyway, I don't think this is something that can easily be avoided. With Edge, everything happens asynchronously (even the instantiation), including the navigation for which you experience the delay. Avoiding that would probably require a synchronous execution of this without any UI refresh, which in turn would/could lead to bad UI responsiveness.

selundqma · 2025-03-21T09:42:13Z

Hi @HeikoKlare ! Thank you for your response! I tried to measure the delay in VLC, but it just won´t show a good enough time resolution. I will try to attach a small video clip here (very minimal) which shows the appearance of the dialog frame and then the text in the browser.. maybe you can get a feeling of the delay then.

recording.mp4

This commit makes sure while calling Edge::getWebViewWrapper with waitForLastPEndingLast set to true that the method also checks for the completion of the webViewWrapperFuture before calling a join() on it, which can some time lead to deadlock as we allow forced execptional completion of lastWebViewTask on timeout. contributes to eclipse-platform#1466

This commit makes sure while calling Edge::getWebViewWrapper with waitForPendingWebviewTasksToFinish set to true that the method also checks for the completion of the webViewWrapperFuture before calling a join() on it, which can some time lead to deadlock as we allow forced execptional completion of lastWebViewTask on timeout. contributes to eclipse-platform#1466

This commit cotributes to executing the registered listeners of Edge browser on Browser callbacks in a asynchronous fashion making sure no WebView related task is executed while a WebView callback is already executing making sure there's no deadlock. contributes to eclipse-platform#1771 and eclipse-platform#1919

This commit makes sure while calling Edge::getWebViewWrapper with waitForPendingWebviewTasksToFinish set to true that the method also checks for the completion of the webViewWrapperFuture before calling a join() on it, which can some time lead to deadlock as we allow forced execptional completion of lastWebViewTask on timeout. contributes to #1466

This commit cotributes to executing the registered listeners of Edge browser on Browser callbacks in a asynchronous fashion making sure no WebView related task is executed while a WebView callback is already executing making sure there's no deadlock. contributes to eclipse-platform#1771 and eclipse-platform#1919

This commit cotributes to replicating the behaviour of Edge:evaluate as it is in WebKit - it must not wait for the execution of script to obtain the result, in case evaluate is called inside a WebView callback. This commit also makes sure that OpenWindowListeners are execute synchronously or asynchronously depending on if the handleNewWindowRequested is called from the evaluate script. Moreover, this enables all the tests which were failing because of Edge:evaluate limitations. contributes to eclipse-platform#1771 and eclipse-platform#1919

RedeemerSK · 2025-04-16T20:08:06Z

Hello
As advised by latest "New & Noteworthy", I'm reporting an issue I found with Edge browser, see #2029.

ilopezv · 2025-04-23T09:08:58Z

this change generate an issue on windows 10 as you can see at: spring-projects/spring-tools#1542 (comment)

martinlippert · 2025-04-23T09:09:26Z

Users reported an issue with this running on Windows 10: spring-projects/spring-tools#1542 - the workaround mentioned in the n&n works for them (setting the internal engine back to IE), but maybe worth to take a deeper look.

martinlippert · 2025-04-23T09:10:32Z

Side note: the mentioned versions of Spring Tools (4.29.0, 4.29.1, and 4.30.0 are all based on the Eclipse 2025-03 release)

fedejeanne · 2025-04-23T09:54:21Z

Thank you @ilopezv and @martinlippert for the info. I bet it has something to do with the "modal" pop-ups. See eclipse-platform/eclipse.platform#1822

sratz · 2025-04-25T12:08:32Z

Thank you @ilopezv and @martinlippert for the info. I bet it has something to do with the "modal" pop-ups. See eclipse-platform/eclipse.platform#1822

I think it's #1912 (fixed with #1920)

sratz added the edge Edge Browser label Sep 12, 2024

amartya4256 mentioned this issue Oct 15, 2024

Edge Browser: Replace BrowserInformationControl on Mouse event vi-eclipse/Eclipse-Platform#133

Closed

HeikoKlare pinned this issue Oct 30, 2024

fedejeanne mentioned this issue Nov 13, 2024

Add N&N entry for the Edge Browser. eclipse-platform/www.eclipse.org-eclipse#250

Merged

1 task

HeikoKlare mentioned this issue Dec 2, 2024

Make Edge the Default Browser on Windows vi-eclipse/Eclipse-Platform#90

Closed

4 tasks

HeikoKlare mentioned this issue Dec 6, 2024

Use Edge/WebView2 as the default browser on Windows #1466 #1637

Merged

wimjongman mentioned this issue Dec 10, 2024

Browser View templates should use SWT.DEFAULT as browser style eclipse-pde/eclipse.pde#1509

Closed

fedejeanne unpinned this issue Dec 20, 2024

amartya4256 mentioned this issue Feb 4, 2025

WebViewWrapperFuture handling on job termination timeout #1752

Merged

amartya4256 mentioned this issue Mar 31, 2025

Fix Edge::getWebViewWrapper deadlock threat #1466 #1966

Merged

fedejeanne closed this as completed in c2136c9 Apr 9, 2025

HeikoKlare reopened this Apr 14, 2025

martinlippert mentioned this issue Apr 23, 2025

STS 4.29.0, 4.29.1 losts focus and opens external browser when I try to see context help spring-projects/spring-tools#1542

Closed

sratz pinned this issue Apr 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Edge: Roadmap to making edge the default browser on Windows #1466

Edge: Roadmap to making edge the default browser on Windows #1466

sratz commented Sep 12, 2024 •

edited

Loading

HeikoKlare commented Mar 21, 2025

selundqma commented Mar 21, 2025

RedeemerSK commented Apr 16, 2025

ilopezv commented Apr 23, 2025

martinlippert commented Apr 23, 2025

martinlippert commented Apr 23, 2025 •

edited

Loading

fedejeanne commented Apr 23, 2025

sratz commented Apr 25, 2025

Edge: Roadmap to making edge the default browser on Windows #1466

Edge: Roadmap to making edge the default browser on Windows #1466

Comments

sratz commented Sep 12, 2024 • edited Loading

Background

Goal

Proposal

Issues

Blocker / Major

Minor

Uncategorized

PDE

Out-of-scope (e.g. Edge-specific API)

Browser-agnostic feature requests

HeikoKlare commented Mar 21, 2025

selundqma commented Mar 21, 2025

RedeemerSK commented Apr 16, 2025

ilopezv commented Apr 23, 2025

martinlippert commented Apr 23, 2025

martinlippert commented Apr 23, 2025 • edited Loading

fedejeanne commented Apr 23, 2025

sratz commented Apr 25, 2025

sratz commented Sep 12, 2024 •

edited

Loading

martinlippert commented Apr 23, 2025 •

edited

Loading