-
Notifications
You must be signed in to change notification settings - Fork 187
Run browser tests against a local HttpServer #2825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Run browser tests against a local HttpServer #2825
Conversation
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
|
The Windows tests I modified are currently failing - I tried to make these new test more robust. For example in the POST test we were just checking that the returned data was "big enough" without checking content. I have changed that to make sure the results are exactly as expected, which works on Linux. But Edge + IE both re-interpret/re-format the HTML leading to comparison errors. For example: expected: I also think newlines change too. I'll provide an update that loosens the new requirements I just added. This new server uses http://localhost:PORT where PORT is assigned per test (standard way using port 0 to get free port). A while ago all the tests were changed from http: -> https: and this goes back to http:. There is a comment in the code that said:
But the tests all seem to pass on macOS. I will spin this up on my mac machine to make sure they work locally too. I can add https to the webserver, but there is a few hoops to jump through to make keys. However I don't think the functionality being tested needs https. In reality we should have some https tests - for example to make sure that failed certs are somewhat displayed to users, but AFAICT there are no such tests today. |
42eca89 to
248607a
Compare
This is really a parent commit - PR #2824 problem. |
Test Results 115 files - 3 115 suites - 3 13m 23s ⏱️ - 2m 52s Results for commit d6f9bb5. ± Comparison against base commit a0d6ffc. This pull request removes 37 tests.This pull request skips 1 test.♻️ This comment has been updated with latest results. |
248607a to
7248adc
Compare
For a while we have suffered with patchy tests due to limited connectivity to external websites when running Browser tests. This commit brings in a new Http Server based on the now available Java 21 simple web server available in the JDK. This is sufficient to test the various paths currently used in the browser tests, and make them reliable (or at least more resilient against external sites going dark) Fixes eclipse-platform#2804 Fixes eclipse-platform#2561
7248adc to
d6f9bb5
Compare
For a while we have suffered with patchy tests due to limited connectivity to external websites when running Browser tests.
This commit brings in a new Http Server based on the now available Java 21 simple web server available in the JDK. This is sufficient to test the various paths currently used in the browser tests, and make them reliable (or at least more resilient against external sites going dark)
Fixes #2804
Fixes #2561
This has as a parent commit PR #2824