Skip to content

Conversation

@al-noori
Copy link
Contributor

All usages of the stated constructor with an additional GC initialization are now replaced by an ImageGcDrawer and the Image(device, gc int, int) constructor afterwards in examples/graphics.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

examples/org.eclipse.swt.examples/META-INF/MANIFEST.MF

Warning

🚧 This PR cannot be modified by maintainers because edits are disabled or it is created from an organization repository. To obtain the required changes apply the git patch manually as an additional commit.

Git patch
From c70177da5710501e5a627a684f7c18b0091c3614 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 1 Dec 2025 10:18:24 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/examples/org.eclipse.swt.examples/META-INF/MANIFEST.MF b/examples/org.eclipse.swt.examples/META-INF/MANIFEST.MF
index 9b80453c74..98a229b574 100644
--- a/examples/org.eclipse.swt.examples/META-INF/MANIFEST.MF
+++ b/examples/org.eclipse.swt.examples/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %plugin.SWTStandaloneExampleSet.name
 Bundle-SymbolicName: org.eclipse.swt.examples; singleton:=true
-Bundle-Version: 3.108.1000.qualifier
+Bundle-Version: 3.108.1100.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-17
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

akoch-yatta and others added 2 commits December 1, 2025 11:22
All usages of the stated constructor with an additional GC initialization are now replaced by an ImageGcDrawer and the Image(device, gc int, int) constructor afterwards in examples/graphics.
@akoch-yatta akoch-yatta force-pushed the al-noori/ReplaceImagegcDrawerInGraphics branch from 9b40ab7 to 68200d6 Compare December 1, 2025 10:23
@akoch-yatta
Copy link
Contributor

If I try this PR on a setup 100% primary, 175% secondary I get the following issue:
image

To reproduce:

  1. Open the ControlExample (with vm args -Dswt.autoScale=quarter -Dswt.autoScale.updateOnRuntime=true) (on primary)
  2. Open Tree Tab
  3. Change background color in "Colors and Fonts"
  4. Move to secondary monitor

I get the same effect on master, when I change the color, while being on the secondary monitor, but it is happening now on DPI change as well (because the handle is now recreated in that scenario as well)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Test Results

  118 files  ±0    118 suites  ±0   15m 26s ⏱️ +13s
4 653 tests ±0  4 636 ✅ ±0  17 💤 ±0  0 ❌ ±0 
  338 runs  ±0    334 ✅ ±0   4 💤 ±0  0 ❌ ±0 

Results for commit 68200d6. ± Comparison against base commit 77f9654.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Image(device,int,int) constructor in examples/graphics

3 participants