Skip to content

Commit c1c681a

Browse files
committed
FindReplaceOverlay: update position and size while not visible #2478
When changing position and/or size of the editor of a FindReplaceOverlay while it is hidden, e.g., because another editor in the same editor stack is active, the position and size of the overlay is not updated accordingly. Thus, when making the editor of that overlay active again, its position relative to the editor and size is still the same as before another editor was set active, i.e., it is usually wrong. With this change, the size and position of an overlay is always updated upon resize operations of the target editor, even if the editor is not visible. Fixes #2478
1 parent eacd0b4 commit c1c681a

File tree

1 file changed

+1
-1
lines changed
  • bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay

1 file changed

+1
-1
lines changed

bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlay.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ private void performSelectAll() {
204204
.controlResizedAdapter(__ -> asyncExecIfOpen(FindReplaceOverlay.this::updatePlacementAndVisibility));
205205

206206
private void asyncExecIfOpen(Runnable operation) {
207-
if (!containerControl.isDisposed() && containerControl.isVisible()) {
207+
if (!containerControl.isDisposed()) {
208208
containerControl.getDisplay().asyncExec(() -> {
209209
if (containerControl != null || containerControl.isDisposed()) {
210210
operation.run();

0 commit comments

Comments
 (0)