Skip to content

Make Generic Code Editor default for text files #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vogella opened this issue Nov 20, 2024 · 1 comment · Fixed by #2881 · May be fixed by #2832
Closed

Make Generic Code Editor default for text files #2527

vogella opened this issue Nov 20, 2024 · 1 comment · Fixed by #2881 · May be fixed by #2832
Labels
enhancement New feature or request

Comments

@vogella
Copy link
Contributor

vogella commented Nov 20, 2024

Currently the (old) text editor is still the default for text files.

image

My understanding of #1381 and #1385 is that we agree that the Generic Code editor is the better choice.

Should we also give the Generic Code Editor priority here? cc @mickaelistria and @iloveeclipse
@vogella vogella added the enhancement New feature or request label Nov 20, 2024
@vogella
Copy link
Contributor Author

vogella commented Nov 22, 2024

A user can also not delete the Plain Text Editor association via the UI, remove will not do anything.

image

deepika-u added a commit to deepika-u/eclipse.platform.ui that referenced this issue Mar 11, 2025
@deepika-u
Make ContentTypes->default text editor as Generic Code Editor.
e6d4308 
Fixes eclipse-platform#2527
@deepika-u deepika-u mentioned this issue Mar 11, 2025
Open
deepika-u added a commit to deepika-u/eclipse.platform.ui that referenced this issue Mar 12, 2025
@deepika-u
Make ContentTypes->default text editor as Generic Code Editor.
68fc45c 
Fixes eclipse-platform#2527
deepika-u added a commit to deepika-u/eclipse.platform.ui that referenced this issue Mar 12, 2025
@deepika-u
Make ContentTypes->default text editor as Generic Code Editor.
e1eb5d8 
Fixes eclipse-platform#2527
deepika-u added a commit to deepika-u/eclipse.platform.ui that referenced this issue Mar 17, 2025
@deepika-u
Make ContentTypes->default text editor as Generic Code Editor.
c1517a3 
Fixes eclipse-platform#2527
Make ContentTypes->default text editor as Generic Code Editor.

Fixes eclipse-platform#2527
deepika-u added a commit to deepika-u/eclipse.platform.ui that referenced this issue Mar 17, 2025
@deepika-u
Make ContentTypes->default text editor as Generic Code Editor.
18ee998 
Fixes eclipse-platform#2527
Make ContentTypes->default text editor as Generic Code Editor.

Fixes eclipse-platform#2527
iloveeclipse added a commit to iloveeclipse/eclipse.platform.ui that referenced this issue Apr 1, 2025
@iloveeclipse
Make GenericEditor default editor for org.eclipse.core.runtime.text
62fe486 
Make generic editor default for the base `org.eclipse.core.runtime.text`
content type.

This shouldn't be a breaking change, given that with
b3137d1 customers expecting "old
classic" text editor to be opened by default could customize their
products by adding this line in product customization file:

`org.eclipse.ui.workbench/defaultEditorForContentType_org.eclipse.core.runtime.text=org.eclipse.ui.DefaultTextEditor`

Fixes eclipse-platform#2527
@iloveeclipse iloveeclipse mentioned this issue Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@vogella