Skip to content

[Find/Replace dialog][Linux] "Replace" buttons remain disabled when using "Enter" #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 of 4 tasks
fedejeanne opened this issue Apr 1, 2025 · 3 comments · Fixed by #2882
Closed
3 of 4 tasks

[Find/Replace dialog][Linux] "Replace" buttons remain disabled when using "Enter" #2880

fedejeanne opened this issue Apr 1, 2025 · 3 comments · Fixed by #2882
Assignees
@HeikoKlare
Labels
bug Something isn't working regression
Milestone
4.36 M2

Comments

@fedejeanne
Copy link
Contributor

fedejeanne commented Apr 1, 2025 •
edited
Loading

Let's make sure issue is not already fixed in latest builds first.

Steps to reproduce

Same as https://bugs.eclipse.org/bugs/show_bug.cgi?id=410603

On Linux

  • Open a file
  • Make sure no text is selected
  • Open the "old" search dialog (Ctrl + f)
  • Search for something that is in the file
  • Hit Enter --> The "replace" buttons remain disabled.

When using the mouse to click the "Find" button, everything works as expected.

Reproducible on

  • Windows
  • Linux
  • Mac (??? not tested)

Considerations

I was made aware of the bug when working on another PR (see #2876 (comment)) but it turns out that my PR did not cause it so reverting the mentioned changes (see #2879) doesn't fix it (maybe that PR is part of the fix but it's not the complete fix).

Community

  • I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

Disclaimer

I can't work on this right now so I'm adding the tag "help wanted". Feel free to jump in.
@fedejeanne fedejeanne added bug Something isn't working help wanted Extra attention is needed labels Apr 1, 2025
@fedejeanne fedejeanne mentioned this issue Apr 1, 2025
Merged
@iloveeclipse
Copy link
Member

Search for something that is in the file

"Replace" is always enabled for me following the steps above.

What is missing and is a precondition for the bug:

If nothing is selected in the editor and Ctrl+F is used to open search dialog, "Replace" button remains disabled if hitting "Enter" key.

Note: only if "Find" button is used and something is found & selected in the editor, "Replace" button will be enabled.

So Enter key listener seem to invoke the "find next" functionality but misses to update "Replace" button state.

@fedejeanne
Copy link
Contributor Author

I updated the description, thank you

iloveeclipse added a commit to iloveeclipse/eclipse.platform.ui that referenced this issue Apr 1, 2025
@iloveeclipse
[Find/Replace dialog][Linux] "Replace" buttons remain disabled when
cce2a05 
using "Enter"

Fixes eclipse-platform#2880
@iloveeclipse iloveeclipse mentioned this issue Apr 1, 2025
Merged
@iloveeclipse
Copy link
Member

On Enter the "Replace" button is properly updated for the first time,
called from

eclipse.platform.ui/bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceDialog.java

Line 315 in a27e79a

updateButtonState(!somethingFound);

but it is immediately disabled via call from

eclipse.platform.ui/bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceDialog.java

Line 649 in a27e79a

updateButtonState(!findReplaceLogic.isActive(SearchOptions.INCREMENTAL));

via this stack

Thread [main] (Suspended)	
	FindReplaceDialog.updateButtonState(boolean) line: 1104	
	FindReplaceDialog.lambda$1() line: 649	
	Lambda.run() line: not available [local variables unavailable]	
	FindReplaceDialog$InputModifyListener.modifyText(ModifyEvent) line: 147	
	TypedListener.handleEvent(Event) line: 217	
	EventTable.sendEvent(Event) line: 91	
	Display.sendEvent(EventTable, Event) line: 5864	
	Combo(Widget).sendEvent(Event) line: 1652	
	Display.runDeferredEvents() line: 5074	
	Display.readAndDispatch() line: 4524

What makes me wonder why do we have two calls to modificationHandler.run() from modifyText()?

The first call seem to be unneeded:

eclipse.platform.ui/bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceDialog.java

Line 147 in a27e79a

modificationHandler.run();

I've created PR: #2882

HeikoKlare pushed a commit to iloveeclipse/eclipse.platform.ui that referenced this issue Apr 4, 2025
@iloveeclipse @HeikoKlare
[Find/Replace dialog][Linux] "Replace" buttons remain disabled when
4fdb779 
using "Enter"

Fixes eclipse-platform#2880
HeikoKlare pushed a commit to iloveeclipse/eclipse.platform.ui that referenced this issue Apr 4, 2025
@iloveeclipse @HeikoKlare
[Find/Replace dialog][Linux] "Replace" buttons remain disabled when
97630a6 
using "Enter"

Fixes eclipse-platform#2880
iloveeclipse added a commit that referenced this issue Apr 14, 2025
@iloveeclipse
[Find/Replace dialog][Linux] "Replace" buttons remain disabled when
18b694c 
using "Enter"

Fixes #2880
@iloveeclipse iloveeclipse removed the help wanted Extra attention is needed label Apr 14, 2025
@iloveeclipse iloveeclipse added this to the 4.36 M2 milestone Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeikoKlare HeikoKlare

Labels
bug Something isn't working regression
Projects
None yet
Milestone
4.36 M2
3 participants
@HeikoKlare @iloveeclipse @fedejeanne