Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Proxy implementation #1780

Open
lgblaumeiser opened this issue Feb 3, 2025 · 4 comments
Open

HTTP Proxy implementation #1780

lgblaumeiser opened this issue Feb 3, 2025 · 4 comments
Labels
enhancement New feature or request triage all new issues awaiting classification

Comments

@lgblaumeiser
Copy link
Contributor

WHAT

The current HTTP proxy implementation upstream has some shortcomings. Major issue is, that depending on the situation, masking a 4xx error coming from the backend by translating it into a 500 status code can be the right thing to do as it indicates a configuration error on the provider side, or wrong, as the status code was motivated by a user error. Currently, in the proxy masks all 4xx status codes to 500.

Based on a request to upstream, a discussion arose which will lead to a decision of the upstream committer group soon. Based on this decision, downstream activities will be needed to keep the functionality of a HTTP proxy with improved status code handling.

WHY

To keep the HTTP proxy functionality stable although upstream changes will occur.

HOW

The downstream implementation should be based on the upstream code base.

@lgblaumeiser lgblaumeiser added enhancement New feature or request triage all new issues awaiting classification labels Feb 3, 2025
@github-project-automation github-project-automation bot moved this to Open in EDC Board Feb 3, 2025
@arnoweiss
Copy link
Contributor

Can you link the upstream discussion?

@lgblaumeiser
Copy link
Contributor Author

@ndr-brt , is there any documentation of the upstream discussion/decision?

@ndr-brt
Copy link
Contributor

ndr-brt commented Feb 7, 2025

@arnoweiss Discussion happened during the committer group meeting, this is the Decision Record:
eclipse-edc/Connector#4805

@arnoweiss
Copy link
Contributor

Oh wow, that goes quite a bit further than this ticket. Thanks for the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage all new issues awaiting classification
Projects
Status: Open
Development

No branches or pull requests

3 participants