Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linting Issues #309

Closed
lukas-he opened this issue Mar 3, 2025 · 3 comments
Closed

Fix Linting Issues #309

lukas-he opened this issue Mar 3, 2025 · 3 comments

Comments

@lukas-he
Copy link
Contributor

lukas-he commented Mar 3, 2025 •
edited
Loading

There are several warnings in the Linting CI step which causes the CI to fail. This issue aims to fix them. The following PRs provide examples for the warnings:
@PLeVasseur
Copy link
Contributor

Hey @lukas-he -- help me understand: is this the same as #298 or different?

@PLeVasseur PLeVasseur mentioned this issue Mar 6, 2025
Merged
@lukas-he
Copy link
Contributor Author

lukas-he commented Mar 7, 2025

We should discuss upgrading to clang-tidy 13 before tackling the linting, cf. #300

@PLeVasseur
Copy link
Contributor

Closing as a duplicate of #298. Thank you for raising the issue though @lukas-he!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PLeVasseur @lukas-he