Error processing extensions with a version containing a plus sign

[ikopylov]

According to the semantic version documentation (https://semver.org/), the version number 1.0.0+10 is valid. I can successfully publish an extension with this version, but later when I try to download it, I get an error. Moreover, after uploading an extension with this version, it becomes impossible to open the page of this extension (error 403 is displayed). The reason is the presence of the + sign, it is processed incorrectly by marketplace

[netomi]

The + sign needs to be url encoded as + has a special meaning in URLs (= whitespace).

For example:

fails:

https://openvsx.eclipsecontent.org/jkb22/jkb-test/25.1204.14182+24890/readme.md

works:

https://openvsx.eclipsecontent.org/jkb22/jkb-test/25.1204.14182%2b24890/readme.md

[netomi]

the current codes uses org.springframework.web.util.UriUtils.encodePathSegment(segment, StandardCharsets.UTF_8) to encode path segments like the version or extension id, but that does not encode + it seems.

[netomi]

That problem is also specific to AWS S3, see here: https://stackoverflow.com/a/36758133

They treat a + sign as space anywhere in an URL, which is against the specification where the + sign should only be treated as a space in a query parameter, otherwhise it should be treated literally.

Tbh I dont know how to solve that for S3.