Legacy client download (#85)

* implement legacy client download

* cleanup

Author: malmans2

cads_api_client/legacy_api_client.py

@@ -2,6 +2,7 @@
 
 import functools
 import logging
+import typing
 import warnings
 from types import TracebackType
 from typing import Any, Callable, TypeVar, cast, overload
@@ -208,8 +209,22 @@ def workflow(self, code, *args, **kwargs):  # type: ignore
     def status(self, context=None):  # type: ignore
         self.raise_not_implemented_error()
 
-    def download(self, results, targets=None):  # type: ignore
-        self.raise_not_implemented_error()
+    @typing.no_type_check
+    def _download(self, results, targets=None):
+        if isinstance(results, (processing.Results, processing.Remote)):
+            if targets:
+                path = targets.pop(0)
+            else:
+                path = None
+            return results.download(path)
+
+        if isinstance(results, (list, tuple)):
+            return [self._download(x, targets) for x in results]
+
+        if isinstance(results, dict):
+            self.raise_not_implemented_error()
+
+        return results
 
     def remote(self, url):  # type: ignore
         self.raise_not_implemented_error()

tests/integration_test_70_legacy_api_client.py

@@ -214,9 +214,29 @@ def test_legacy_api_client_logging(
     client.info("Info message")
     client.warning("Warning message")
     client.error("Error message")
-    print(caplog.record_tuples)
     assert caplog.record_tuples == [
         ("cads_api_client.legacy_api_client", 20, "Info message"),
         ("cads_api_client.legacy_api_client", 30, "Warning message"),
         ("cads_api_client.legacy_api_client", 40, "Error message"),
     ]
+
+
+def test_legacy_api_client_download(
+    tmp_path: pathlib.Path,
+    api_root_url: str,
+    api_anon_key: str,
+) -> None:
+    client = legacy_api_client.LegacyApiClient(
+        url=api_root_url,
+        key=api_anon_key,
+        retry_max=0,
+        wait_until_complete=False,
+    )
+    remote = client.retrieve("test-adaptor-dummy", {"size": 1})
+    assert isinstance(remote, processing.Remote)
+
+    results = (remote, remote.make_results())
+    target1 = str(tmp_path / "remote.grib")
+    target2 = str(tmp_path / "results.grib")
+    assert client.download(results, [target1, target2]) == [target1, target2]
+    assert os.path.getsize(target1) == os.path.getsize(target2) == 1