Merge pull request #64 from ecmwf-projects/template-update

mcucchi9 · web-flow · commit ae3bbe5ba6cd · 2023-11-17T15:22:51.000+01:00
template update
diff --git a/.cruft.json b/.cruft.json
@@ -1,6 +1,6 @@
 {
   "template": "https://github.com/ecmwf-projects/cookiecutter-conda-package",
-  "commit": "22b85d3aca63d05f4a19f1a531bcea311617f4cd",
+  "commit": "ce9afbb8510935c0206746d26f05f6b80e9d0087",
   "checkout": null,
   "context": {
     "cookiecutter": {
diff --git a/.github/workflows/on-push.yml b/.github/workflows/on-push.yml
@@ -33,16 +33,18 @@ jobs:
 
     steps:
     - uses: actions/checkout@v4
+    - uses: actions/setup-python@v4
+      with:
+        python-version: 3.x
     - name: Install conda-merge
       run: |
-        $CONDA/bin/python -m pip install conda-merge
+        python -m pip install conda-merge
     - name: Combine environments
       run: |
         for SUFFIX in ci integration; do
-        $CONDA/bin/conda-merge ci/environment-$SUFFIX.yml environment.yml > ci/combined-environment-$SUFFIX.yml || exit
+        conda-merge ci/environment-$SUFFIX.yml environment.yml > ci/combined-environment-$SUFFIX.yml || exit
         done
-    - name: Archive combined environments
-      uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v3
       with:
         name: combined-environments
         path: ci/combined-environment-*.yml
@@ -57,17 +59,20 @@ jobs:
 
     steps:
     - uses: actions/checkout@v4
-    - name: Download combined environments
-      uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v3
       with:
         name: combined-environments
         path: ci
-    - name: Install Conda environment with Micromamba
-      uses: mamba-org/setup-micromamba@v1
+    - name: Get current date
+      id: date
+      run: echo "date=$(date +%Y-%m-%d)" >> "${GITHUB_OUTPUT}"
+    - uses: mamba-org/setup-micromamba@v1
       with:
         environment-file: ci/combined-environment-ci.yml
         environment-name: DEVELOP
         cache-environment: true
+        cache-environment-key: environment-${{ steps.date.outputs.date }}
+        cache-downloads-key: downloads-${{ steps.date.outputs.date }}
         create-args: >-
           python=${{ matrix.python-version }}
     - name: Install package
@@ -83,17 +88,20 @@ jobs:
 
     steps:
     - uses: actions/checkout@v4
-    - name: Download combined environments
-      uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v3
       with:
         name: combined-environments
         path: ci
-    - name: Install Conda environment with Micromamba
-      uses: mamba-org/setup-micromamba@v1
+    - name: Get current date
+      id: date
+      run: echo "date=$(date +%Y-%m-%d)" >> "${GITHUB_OUTPUT}"
+    - uses: mamba-org/setup-micromamba@v1
       with:
         environment-file: ci/combined-environment-ci.yml
         environment-name: DEVELOP
         cache-environment: true
+        cache-environment-key: environment-${{ steps.date.outputs.date }}
+        cache-downloads-key: downloads-${{ steps.date.outputs.date }}
         create-args: >-
           python=3.10
     - name: Install package
@@ -109,17 +117,20 @@ jobs:
 
     steps:
     - uses: actions/checkout@v4
-    - name: Download combined environments
-      uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v3
       with:
         name: combined-environments
         path: ci
-    - name: Install Conda environment with Micromamba
-      uses: mamba-org/setup-micromamba@v1
+    - name: Get current date
+      id: date
+      run: echo "date=$(date +%Y-%m-%d)" >> "${GITHUB_OUTPUT}"
+    - uses: mamba-org/setup-micromamba@v1
       with:
         environment-file: ci/combined-environment-ci.yml
         environment-name: DEVELOP
         cache-environment: true
+        cache-environment-key: environment-${{ steps.date.outputs.date }}
+        cache-downloads-key: downloads-${{ steps.date.outputs.date }}
         create-args: >-
           python=3.10
     - name: Install package
@@ -145,17 +156,20 @@ jobs:
 
     steps:
     - uses: actions/checkout@v4
-    - name: Download combined environments
-      uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v3
       with:
         name: combined-environments
         path: ci
-    - name: Install Conda environment with Micromamba
-      uses: mamba-org/setup-micromamba@v1
+    - name: Get current date
+      id: date
+      run: echo "date=$(date +%Y-%m-%d)" >> "${GITHUB_OUTPUT}"
+    - uses: mamba-org/setup-micromamba@v1
       with:
         environment-file: ci/combined-environment${{ matrix.extra }}.yml
         environment-name: DEVELOP${{ matrix.extra }}
         cache-environment: true
+        cache-environment-key: environment-${{ steps.date.outputs.date }}
+        cache-downloads-key: downloads-${{ steps.date.outputs.date }}
         create-args: >-
           python=${{ matrix.python-version }}
     - name: Install package
@@ -168,11 +182,6 @@ jobs:
   distribution:
     runs-on: ubuntu-latest
     needs: [unit-tests, type-check, docs-build, integration-tests]
-    environment:
-      name: pypi
-      url: https://pypi.org/p/ogc-api-processes-fastapi
-    permissions:
-      id-token: write  # IMPORTANT: this permission is mandatory for trusted publish
     if: |
       always() &&
       needs.unit-tests.result == 'success' &&
@@ -182,18 +191,47 @@ jobs:
 
     steps:
     - uses: actions/checkout@v4
-    - name: Install packages
+    - uses: actions/setup-python@v4
+      with:
+        python-version: '3.10'
+    - name: Install package
       run: |
-        $CONDA/bin/python -m pip install build twine
-    - name: Build distributions
+        python -m pip install --upgrade pip
+        python -m pip install build twine
+    - name: Build distribution
       run: |
-        $CONDA/bin/python -m build
+        python -m build
     - name: Check wheels
       run: |
         cd dist || exit
-        $CONDA/bin/python -m pip install ogc_api_processes_fastapi*.whl || exit
-        $CONDA/bin/python -m twine check * || exit
-        $CONDA/bin/python -c "import ogc_api_processes_fastapi"
-    - name: Publish a Python distribution to PyPI
-      if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
-      uses: pypa/gh-action-pypi-publish@release/v1
+        python -m pip install ogc_api_processes_fastapi*.whl || exit
+        python -m twine check --strict * || exit
+        python -c "import ogc_api_processes_fastapi" || exit
+        cd ..
+    - uses: actions/upload-artifact@v3
+      with:
+        name: distribution
+        path: dist
+
+  upload-to-pypi:
+    runs-on: ubuntu-latest
+    needs: distribution
+    if: |
+      always() &&
+      needs.distribution.result == 'success' &&
+      github.event_name == 'push' &&
+      startsWith(github.ref, 'refs/tags')
+    environment:
+      name: pypi
+      url: https://pypi.org/p/ogc-api-processes-fastapi
+    permissions:
+      id-token: write  # IMPORTANT: this permission is mandatory for trusted publish
+
+    steps:
+    - uses: actions/download-artifact@v3
+      with:
+        name: distribution
+        path: dist
+    - uses: pypa/gh-action-pypi-publish@v1.8.10
+      with:
+        verbose: true
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -8,22 +8,20 @@ repos:
   - id: check-yaml
   - id: check-toml
   - id: check-added-large-files
+  - id: check-merge-conflict
   - id: debug-statements
   - id: mixed-line-ending
-- repo: https://github.com/psf/black
-  rev: 23.9.1
-  hooks:
-  - id: black
 - repo: https://github.com/keewis/blackdoc
-  rev: v0.3.8
+  rev: v0.3.9
   hooks:
   - id: blackdoc
-    additional_dependencies: [black==22.3.0]
+    additional_dependencies: [black==23.11.0]
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.0.292
+  rev: v0.1.5
   hooks:
   - id: ruff
     args: [--fix, --show-fixes]
+  - id: ruff-format
 - repo: https://github.com/executablebooks/mdformat
   rev: 0.7.17
   hooks:
diff --git a/ogc_api_processes_fastapi/main.py b/ogc_api_processes_fastapi/main.py
@@ -39,7 +39,7 @@ def register_route(
         response_model_exclude_unset=True,
         response_model_exclude_none=True,
         endpoint=route_endpoint,
-        **config.ROUTES[route_name].model_dump(exclude={"client_method"})
+        **config.ROUTES[route_name].model_dump(exclude={"client_method"}),
     )
 
 
diff --git a/pyproject.toml b/pyproject.toml
@@ -36,8 +36,9 @@ ignore = [
   # pydocstyle: Missing Docstrings
   "D1"
 ]
-# Black line length is 88, but black does not format comments.
-line-length = 110
+# Same as Black.
+indent-width = 4
+line-length = 88
 select = [
   # pyflakes
   "F",
@@ -50,6 +51,9 @@ select = [
   "D"
 ]
 
+[tool.ruff.lint.pycodestyle]
+max-line-length = 110
+
 [tool.ruff.pydocstyle]
 convention = "numpy"
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"template": "https://github.com/ecmwf-projects/cookiecutter-conda-package",`
`3`		`- "commit": "22b85d3aca63d05f4a19f1a531bcea311617f4cd",`
	`3`	`+ "commit": "ce9afbb8510935c0206746d26f05f6b80e9d0087",`
`4`	`4`	`"checkout": null,`
`5`	`5`	`"context": {`
`6`	`6`	`"cookiecutter": {`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ def register_route(`
`39`	`39`	`response_model_exclude_unset=True,`
`40`	`40`	`response_model_exclude_none=True,`
`41`	`41`	`endpoint=route_endpoint,`
`42`		`- **config.ROUTES[route_name].model_dump(exclude={"client_method"})`
	`42`	`+ **config.ROUTES[route_name].model_dump(exclude={"client_method"}),`
`43`	`43`	`)`
`44`	`44`
`45`	`45`