qa

Author: floriankrb

Diff for: pyproject.toml

@@ -97,9 +97,9 @@ optional-dependencies.tests = [
 optional-dependencies.xarray = [
   "gcsfs",
   "kerchunk",
-  "pandas", 
-  "pystac_client",
-  "planetary_computer",
+  "pandas",
+  "planetary-computer",
+  "pystac-client",
 ]
 
 urls.Documentation = "https://anemoi-datasets.readthedocs.io/"

Diff for: src/anemoi/datasets/create/__init__.py

@@ -7,7 +7,6 @@
 # nor does it submit to any jurisdiction.
 #
 
-import cftime
 import datetime
 import json
 import logging
@@ -17,6 +16,7 @@
 import warnings
 from functools import cached_property
 
+import cftime
 import numpy as np
 import tqdm
 from anemoi.utils.config import DotDict as DotDict
@@ -69,7 +69,7 @@ def json_tidy(o):
 
     if isinstance(o, cftime.DatetimeJulian):
         import pandas as pd
-        
+
         o = pd.Timestamp(
             o.year,
             o.month,

Diff for: src/anemoi/datasets/create/functions/sources/xarray/fieldlist.py

@@ -60,15 +60,15 @@ def from_xarray(cls, ds, flavour=None):
                     flavour = yaml.safe_load(f)
                 else:
                     flavour = json.load(f)
-                    
+
         if isinstance(flavour, dict):
             flavour_coords = [coords["name"] for coords in flavour["rules"].values()]
             ds_dims = [dim for dim in ds._dims]
             for dim in ds_dims:
-                    if dim in flavour_coords and dim not in ds._coord_names:
-                        ds = ds.assign_coords({dim:ds[dim]})
-                    else:
-                        pass
+                if dim in flavour_coords and dim not in ds._coord_names:
+                    ds = ds.assign_coords({dim: ds[dim]})
+                else:
+                    pass
 
         guess = CoordinateGuesser.from_flavour(ds, flavour)
 

Diff for: src/anemoi/datasets/data/stores.py

@@ -94,8 +94,8 @@ def __init__(self, data_catalog_id):
         self.data_catalog_id = data_catalog_id
 
     def __getitem__(self):
-        import pystac_client
         import planetary_computer
+        import pystac_client
 
         catalog = pystac_client.Client.open(
             "https://planetarycomputer.microsoft.com/api/stac/v1/",
@@ -157,7 +157,7 @@ def name_to_zarr_store(path_or_url):
             s3_url = f"s3://{bits[0]}{parsed.path}"
             store = S3Store(s3_url, region=bits[2])
         elif store.startswith("https://planetarycomputer.microsoft.com/"):
-            data_catalog_id = store.rsplit('/', 1)[-1]
+            data_catalog_id = store.rsplit("/", 1)[-1]
             store = PlanetaryComputerStore(data_catalog_id).__getitem__()
         else:
             store = HTTPStore(store)

Diff for: tests/xarray/test_zarr.py

@@ -11,8 +11,8 @@
 import xarray as xr
 
 from anemoi.datasets.create.functions.sources.xarray import XarrayFieldList
-from anemoi.datasets.testing import assert_field_list
 from anemoi.datasets.data.stores import name_to_zarr_store
+from anemoi.datasets.testing import assert_field_list
 
 
 def test_arco_era5_1():