Skip to content

Conversation

@b8raoult
Copy link
Collaborator

@b8raoult b8raoult commented May 12, 2025

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Code Compatibility

  • I have performed a self-review of my code

Code Performance and Testing

  • I have added tests that prove my fix is effective or that my feature works
  • I ran the complete Pytest test suite locally, and they pass

Dependencies

  • I have ensured that the code is still pip-installable after the changes and runs
  • I have tested that new dependencies themselves are pip-installable.

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes


📚 Documentation preview 📚: https://anemoi-datasets--326.org.readthedocs.build/en/326/

@github-actions github-actions bot added bug Something isn't working enhancement New feature or request labels May 12, 2025
@flyIchtus flyIchtus changed the title Feat/abstracting accumulation feat/abstracting accumulation May 16, 2025
@flyIchtus flyIchtus changed the title feat/abstracting accumulation feat: abstracting accumulation May 16, 2025
@flyIchtus flyIchtus marked this pull request as ready for review May 16, 2025 16:41
@github-actions github-actions bot added the tests label May 23, 2025
@github-project-automation github-project-automation bot moved this to Now In Progress in Anemoi-dev May 23, 2025
@floriankrb floriankrb force-pushed the feat/abstracting_accumulation branch from e5e75da to 781e328 Compare November 13, 2025 10:19
@floriankrb floriankrb force-pushed the feat/abstracting_accumulation branch from 82624cd to 71a539b Compare November 13, 2025 14:31
@MeraX
Copy link
Contributor

MeraX commented Nov 14, 2025

Please update the description before merging.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 17, 2025
int
The member number.
"""
# Bug in eccodes has number=0 randomly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been reported in eccodes issues tracker?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it help ro request number:i instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ATS Approval not needed bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request tests

Projects

Status: Now In Progress

Development

Successfully merging this pull request may close these issues.

10 participants