Fix/improve cdv error messages

[Ozaq]

Description

Fixes a segfault I encountered during profiling, adds additional bounds checking and improves error messages.

Commits:

commit 6cb5d11

Fix potential segfault when reading data

A user defined view may not contain fields of different sizes. Now check
and report errors on size mismatches. Prior this could lead to
overwriting memory and segfaulting subsequently.

commit a3d293e

ChunkedDataView adds bounds check

Assert that we are not writng out of bounds when assembling chunk.

Contributor Declaration

By opening this pull request, I affirm the following:

• All authors agree to the Contributor License Agreement.
• The code follows the project's coding standards.
• I have performed self-review and added comments where needed.
• I have added or updated tests to verify that my changes are effective and functional.
• I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-196

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-196

[tbkr]

Not a huge fan of the request passing in the writeInto method but for the sake of readability ok.

[tbkr]

Suggested change

	/// @param request tthat was used to read data from FDB, only used to enhance error messages
	/// @param request that was used to read data from FDB, only used to enhance error messages

[Ozaq]

done

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.42%. Comparing base (156dd71) to head (2462cf7).

Files with missing lines	Patch %	Lines
src/chunked_data_view/GribExtractor.cc	0.00%	19 Missing ⚠️
src/chunked_data_view/ViewPart.cc	0.00%	1 Missing ⚠️
tests/chunked_data_view/test_builder.cc	0.00%	1 Missing ⚠️
tests/chunked_data_view/test_view.cc	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #196      +/-   ##
===========================================
- Coverage    72.46%   72.42%   -0.04%     
===========================================
  Files          360      360              
  Lines        21693    21704      +11     
  Branches      2240     2241       +1     
===========================================
  Hits         15719    15719              
- Misses        5974     5985      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.