[backend] fix: Invalid url in share api endpoint #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmi
reviewed
Oct 23, 2025
| @router.get("/{job_id}/results/{dataset_id}") | ||
| async def get_result( | ||
| job_id: JobId = Depends(validate_job_id), dataset_id: TaskId = Depends(validate_dataset_id), user: UserRead = Depends(current_active_user) | ||
| job_id: JobId = Depends(validate_job_id), dataset_id: TaskId = Depends(validate_dataset_id), user: UserRead = Depends(current_active_optional_user) |
Collaborator
There was a problem hiding this comment.
how does this differ from UserRead|None -- because thats what we used so far for like "non-mandatory" auth, haven't we? Should we replace that with this new one everywhere then?
Member
Author
There was a problem hiding this comment.
I believe current_active_user errors if not logged in
Member
Author
There was a problem hiding this comment.
Maybe I missed something with the | None?
Collaborator
There was a problem hiding this comment.
ok lets test it at some point (not required before merge), and have just one way of having optional-auth... because
# grep -R . -e 'UserRead | None' --include '*py' | wc -l
8
tmi
reviewed
Oct 23, 2025
tmi
approved these changes
Oct 23, 2025
HCookie
commented
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FIx incorrect url in share endpoint
Contributor Declaration
By opening this pull request, I affirm the following: