qa

Author: b8raoult

.github/workflows/check-and-publish.yml

@@ -11,21 +11,33 @@ on:
     types: [created]
 
 jobs:
+  quality:
+    name: Code QA
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - run: pip install black flake8 isort
+      - run: black --version
+      - run: isort --check --profile=black .
+      - run: black --check .
+      - run: flake8 .
+
   checks:
     strategy:
       fail-fast: false
       matrix:
         platform: [windows-latest, ubuntu-latest, macos-latest]
         python-version: ["3.6", "3.7", "3.8", "3.9"]
         method: ["conda", "ecmwflibs"]
-        exclude:
-        - platform: windows-latest
-          method: conda
-        - platform: macos-latest
-          method: conda
+        # exclude:
+        # - platform: windows-latest
+        #   method: conda
+        # - platform: macos-latest
+        #   method: conda
 
     name: Python ${{ matrix.python-version }} on ${{ matrix.platform }} (${{ matrix.method }})
     runs-on: ${{ matrix.platform }}
+    needs: quality
 
     steps:
       - uses: actions/checkout@v2

Magics/Magics.py

@@ -10,14 +10,11 @@
 import ctypes
 import ctypes.util
 import json
-import os
 import sys
 
 import numpy as np
 from numpy.ctypeslib import ndpointer
 
-
-
 try:
     import ecmwflibs as findlibs
 except ImportError:
@@ -37,7 +34,7 @@ class FILE(ctypes.Structure):
 
 FILE_p = ctypes.POINTER(FILE)
 
-######################## String conversions ##########################
+####################################################################
 
 
 def _string_to_char(x):
@@ -77,14 +74,18 @@ def wrapped(*args):
     return wrapped
 
 
+def _noop(x):
+    return x
+
+
 if sys.version_info[0] > 2:
     convert_strings = _convert_strings
     char_to_string = _char_to_string
     string_to_char = _string_to_char
 else:
-    convert_strings = lambda x: x
-    char_to_string = lambda x: x
-    string_to_char = lambda x: x
+    convert_strings = _noop
+    char_to_string = _noop
+    string_to_char = _noop
 
 
 ####################################################################
@@ -473,9 +474,9 @@ def eps():
 
 
 ####################################################################
-###
-###  Please note: these two functions changed compared to the previous SWIG based Python interface
-###
+#
+# Please note: these two functions changed compared to the previous SWIG based Python interface
+#
 
 py_metgraph = dll.py_metgraph
 py_metgraph.restype = c_char_p
@@ -496,9 +497,9 @@ def epsinput():
 
 
 ####################################################################
-###
-###  Please note: this function was called mmetbufr to the previous SWIG based Python interface
-###
+#
+# Please note: this function was called mmetbufr to the previous SWIG based Python interface
+#
 
 py_metbufr = dll.py_metbufr
 py_metbufr.restype = c_char_p
@@ -733,9 +734,7 @@ def set1r(name, data):
 
 @checked_return_code
 def set1c(name, data):
-    new_data = []
-    for s in data:
-        new_data.append(string_to_char(s))
+    new_data = [string_to_char(s) for s in data]
     name = string_to_char(name)
     data_p = (c_char_p * (len(new_data)))(*new_data)
     return py_set1c(ctypes.c_char_p(name), data_p, len(new_data))

Magics/__init__.py

@@ -1,5 +1,5 @@
 from __future__ import absolute_import
 
-from .Magics import *
+from .Magics import *  # noqa
 
 __version__ = "1.5.6"

Magics/binary.py

@@ -97,7 +97,7 @@ def text(self):
             r = self.readDouble()
             g = self.readDouble()
             b = self.readDouble()
-            s = self.readDouble()
+            s = self.readDouble()  # noqa
             m = self.readInt()
             texts.append(self.readString(m))
 
@@ -240,7 +240,7 @@ def circle(self):
         x = self.projectX(self.readDouble())
         y = self.projectX(self.readDouble())
         r = self.readDouble()
-        cs = self.readInt()
+        cs = self.readInt()  # noqa
         return
         self.ax.add_patch(
             Circle(