Add an assert that there are less than 2^16 unique strings in a column

TomHodson · TomHodson · commit 8c19e915f7aa · 2024-07-31T15:32:29.000+01:00
diff --git a/src/odc/codec/CodecOptimizer.h b/src/odc/codec/CodecOptimizer.h
@@ -94,6 +94,7 @@ int CodecOptimizer::setOptimalCodecs(core::MetaData& columns)
             case api::STRING:
 				{
                     n = col.coder().numStrings();
+                    ASSERT(n < 65536);
                                         if (n == 1 && col.coder().dataSizeDoubles() == 1)
 						codec = "constant_string";
 					else if(n < 256)

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,7 @@ int CodecOptimizer::setOptimalCodecs(core::MetaData& columns)`
`94`	`94`	`case api::STRING:`
`95`	`95`	`{`
`96`	`96`	`n = col.coder().numStrings();`
	`97`	`+ ASSERT(n < 65536);`
`97`	`98`	`if (n == 1 && col.coder().dataSizeDoubles() == 1)`
`98`	`99`	`codec = "constant_string";`
`99`	`100`	`else if(n < 256)`