Skip to content

Commit a20e1ee

Browse files
committed
Add an assert that there are less than 2^16 unique strings in a column
1 parent 808c9a9 commit a20e1ee

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/odc/codec/CodecOptimizer.h

+5-4
Original file line numberDiff line numberDiff line change
@@ -94,13 +94,14 @@ int CodecOptimizer::setOptimalCodecs(core::MetaData& columns)
9494
case api::STRING:
9595
{
9696
n = col.coder().numStrings();
97-
if (n == 1 && col.coder().dataSizeDoubles() == 1)
97+
ASSERT(n < 65536);
98+
if (n == 1 && col.coder().dataSizeDoubles() == 1) {
9899
codec = "constant_string";
99-
else if(n < 256)
100+
} else if(n < 256) {
100101
codec = "int8_string";
101-
else if(n < 65536)
102+
} else {
102103
codec = "int16_string";
103-
104+
}
104105

105106
std::unique_ptr<core::Codec> newCodec = core::CodecFactory::instance().build<ByteOrder>(codec, col.type());
106107
if (codec == "constant_string") {

0 commit comments

Comments
 (0)