Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The diff's zipnote may need re-ordering #442

Open
jamietanna opened this issue Feb 12, 2024 · 1 comment
Open

The diff's zipnote may need re-ordering #442

jamietanna opened this issue Feb 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jamietanna
Copy link

jamietanna commented Feb 12, 2024

When looking at an example diff https://diff.ecosyste.ms/diff?url_1=https%3A%2F%2Fproxy.golang.org%2Fgithub.com%2Fdeepmap%2Foapi-codegen%2Fv2%2F%40v%2Fv2.0.0.zip&url_2=https%3A%2F%2Fproxy.golang.org%2Fgithub.com%2Fdeepmap%2Foapi-codegen%2Fv2%2F%40v%2Fv2.1.0.zip I see:

-Filename: github.com/deepmap/oapi-codegen/[email protected]/.github/workflows/ci.yml
+Filename: github.com/deepmap/oapi-codegen/[email protected]/.github/release-drafter.yml
 Comment: 
 
-Filename: github.com/deepmap/oapi-codegen/[email protected]/.github/workflows/generate.yml
+Filename: github.com/deepmap/oapi-codegen/[email protected]/.github/workflows/ci.yml
 Comment: 
 
-Filename: github.com/deepmap/oapi-codegen/[email protected]/.github/workflows/lint.yml
+Filename: github.com/deepmap/oapi-codegen/[email protected]/.github/workflows/generate.yml
 Comment: 
 
-Filename: github.com/deepmap/oapi-codegen/[email protected]/.github/workflows/tidy.yml
+Filename: github.com/deepmap/oapi-codegen/[email protected]/.github/workflows/lint.yml
 Comment:

In these cases, the only changes between them are the versions, but we're seeing some of the orders being wrong - maybe we need to recursively sort the filenames before diffing them?

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@andrew andrew added the bug Something isn't working label Feb 12, 2024
@andrew
Copy link
Member

andrew commented Feb 12, 2024

Yeah good point, I wonder what output the underlying tool produces, it’s been a while since I looked at this service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants