Skip to content

Commit a7b9be7

Browse files
committed
nanoduration / nanoduration returns double instead of integer64
1 parent dfc4073 commit a7b9be7

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

ChangeLog

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
2024-05-24 Leonardo Silvestri <[email protected]>
2+
* R/nanoduration.R: duration divided by duration returns double
3+
* inst/tinytest/test_nanoduration.R: additional test for the above
4+
15
2024-05-24 Leonardo Silvestri <[email protected]>
26

37
* inst/include/nanotime/utilities.hpp: Use interface function Rf_asS4

R/nanoduration.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ setMethod("*", c("ANY", "nanoduration"),
439439
##' @rdname nanoduration
440440
setMethod("/", c("nanoduration", "nanoduration"),
441441
function(e1, e2) {
442-
as.integer64(S3Part(e1, strictS3=TRUE) / S3Part(e2, strictS3=TRUE))
442+
S3Part(e1, strictS3=TRUE) / S3Part(e2, strictS3=TRUE)
443443
})
444444
##' @rdname nanoduration
445445
setMethod("/", c("nanoduration", "integer64"),

inst/tinytest/test_nanoduration.R

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,10 @@ expect_error(1.5 / as.nanoduration("00:01:00"), "invalid operand types")
301301
expect_error(as.nanoduration("1:00:00") / "a", "invalid operand types")
302302

303303
##test_nanoduration_div_nanoduration <- function() {
304-
expect_identical(as.nanoduration(6) / as.nanoduration(2), as.integer64(3))
304+
expect_identical(as.nanoduration(6) / as.nanoduration(2), 3.0)
305+
306+
##test_nanoduration_div_nanoduration <- function() {
307+
expect_identical(as.nanoduration(7) / as.nanoduration(2), 3.5)
305308

306309

307310
## unary

0 commit comments

Comments
 (0)