Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify away duplicated spelling of flat initial layer depths. #111

Open
axch opened this issue Apr 20, 2017 · 1 comment
Open

Simplify away duplicated spelling of flat initial layer depths. #111

axch opened this issue Apr 20, 2017 · 1 comment

Comments

@axch
Copy link
Collaborator

axch commented Apr 20, 2017

As noted in #110 (comment), both the Fortran core and the Python wrapper implement the ability to initialize a uniform-depths simulation; and the test cases redundantly invoke both mechanisms.

Things we might do:

  • Remove that defaulting capability from the Fortran core, in order to simplify it and all the parameterization files.
    • Or choose not to, on the grounds of wanting to ship a plausibly flexible core for the benefit of a hypothetical user that might want to run it in isolation.
  • Remove the redundancy from the test case specifications, in favor of using either initHfile or hmean consistently in all circumstances that can be spelled with either.
@edoddridge
Copy link
Owner

The bathymetry input supports a similar shortcut in the Fortran core as well.

I'm not sure that we should remove the functionality from the core. For the hypothetical user who doesn't want the python wrapping, it does provide a useful shortcut. Actually, what I mean is that I'm not sure we should prioritise above other tasks.

However, in both cases I think it would be better to move the variables to the same section of the config file as the filename string. That will at least hint strongly that the two are linked. We could also rename the variables to something more descriptive than hmean and H0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants