fix: add basename to router register to avoid conflicts with services #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @mariajgrimaldi, we were trying to replicate the error, but it was not possible. However, we will keep the error on our radar. Thanks! |
Contributor
|
Hi @mariajgrimaldi, in this PR we add the basename in all the routes. There should no longer be any errors since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves this issue raised in one of our installations after building and deploying an image with this package installed:
It looks like this API endpoint conflicts with the enrollments API from the edx-platform. I'm not sure why, though because our installation has been working fine for some time.