Add loki log handler #173
Add loki log handler #173
Conversation
There was a problem hiding this comment.
I think its ready to go.
There's one question, about having the LOKI url in ENV that needs to be answered, though.
But also believe this is an opportunity to improve the overal logging setup just a bit more even. If there's time for that, I think this would make the system just a bit better :)
apps/mainsite/settings.py
Outdated
| if DOMAIN.startswith('acc') or DOMAIN.startswith('prod'): | ||
| handlers = handlers | { | ||
| 'badgr_debug_loki': { | ||
| 'level': 'DEBUG', # Log level. Required |
There was a problem hiding this comment.
IMHO these comments don't really add much. Instead of documenting what it is, maybe consider commenting why its the value? For "debug" rather obvious and could possibly be gone, but for timeout it would clarify why we chose 1?
Same for # Tags and # Loki URL.
apps/mainsite/settings.py
Outdated
|
|
||
| debug_handlers = ['badgr_debug'] | ||
| SERVER_NAME = os.environ['SERVER_NAME'] | ||
| LOKI_URL = 'http://195.169.124.131:3100/loki/api/v1/push' |
There was a problem hiding this comment.
Should this not also be an os.environ?
There was a problem hiding this comment.
Indeed, would be nicer.
| SERVER_NAME = os.environ['SERVER_NAME'] | ||
| LOKI_URL = 'http://195.169.124.131:3100/loki/api/v1/push' | ||
|
|
||
| if DOMAIN.startswith('acc') or DOMAIN.startswith('prod'): |
There was a problem hiding this comment.
Why do we have a "debug" in prod? Could we add that as comment?
| LOKI_URL = 'http://195.169.124.131:3100/loki/api/v1/push' | ||
|
|
||
| if DOMAIN.startswith('acc') or DOMAIN.startswith('prod'): | ||
| handlers = handlers | { |
There was a problem hiding this comment.
Would it not make more sense to:
- first set up a few handlers objects (console_handler, badgr_events_handler etc)
- then set up loggers using one or more of these handlers
- then use that list to set up the actual LOGGING for this env (prod, dev acc etc) using simple conditionals (prod, acc etc.
That would make it even easier to and cleaner than this PR already makes it, IMHO?
Adding a loki log handler to setting py to automatically forward Badge.Debug logs to central loki server.