From dd90e15045cb6af42ba00ea874f8dc6e78680211 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Esmery?= Date: Fri, 13 Feb 2026 16:50:05 +0100 Subject: [PATCH] Remove costly useless ConvertToHex calls (cherry picked from commit 87ee89811901632af869e05636f6f1d54e447b78) --- Transport/BacnetIpUdpProtocolTransport.cs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Transport/BacnetIpUdpProtocolTransport.cs b/Transport/BacnetIpUdpProtocolTransport.cs index a3fd84f..9f5959c 100644 --- a/Transport/BacnetIpUdpProtocolTransport.cs +++ b/Transport/BacnetIpUdpProtocolTransport.cs @@ -227,7 +227,6 @@ private void OnReceiveData(IAsyncResult asyncResult) } } - var receiveBufferHex = ConvertToHex(receiveBuffer); var receivedLength = receiveBuffer.Length; if (receivedLength == 0) // Empty frame : port scanner maybe @@ -238,7 +237,7 @@ private void OnReceiveData(IAsyncResult asyncResult) if (receivedLength < BVLC.BVLC_HEADER_LENGTH) { - Log.Warn($"Some garbage data got in: {receiveBufferHex}"); + Log.Warn($"Some garbage data got in: {ConvertToHex(receiveBuffer)}"); return; } @@ -247,7 +246,7 @@ private void OnReceiveData(IAsyncResult asyncResult) if (headerLength == -1) { - Log.Warn($"Unknow BVLC Header in: {receiveBufferHex}"); + Log.Warn($"Unknow BVLC Header in: {ConvertToHex(receiveBuffer)}"); return; } @@ -280,7 +279,7 @@ private void OnReceiveData(IAsyncResult asyncResult) if (receivedLength <= headerLength) { - Log.Warn($"Missing data, only header received: {receiveBufferHex}"); + Log.Warn($"Missing data, only header received: {ConvertToHex(receiveBuffer)}"); return; }