Skip to content

Commit 9dfeeca

Browse files
authored
test(finalhandler): skip testing finalhandler >=2.1.0 on Node.js 14 or earlier (#4502)
Obsoletes: #4496
1 parent 1e631e8 commit 9dfeeca

File tree

4 files changed

+103
-39
lines changed

4 files changed

+103
-39
lines changed

Diff for: .tav.yml

+10-2
Original file line numberDiff line numberDiff line change
@@ -447,8 +447,16 @@ fastify:
447447
- node test/instrumentation/modules/fastify/set-framework.test.js
448448

449449
finalhandler:
450-
versions: '*'
451-
commands: node test/instrumentation/modules/finalhandler.test.js
450+
- versions:
451+
mode: max-3
452+
include: '>=1 <2'
453+
node: '>=0.8'
454+
commands: node test/instrumentation/modules/finalhandler.test.js
455+
- versions:
456+
mode: max-3
457+
include: '>=2 <3'
458+
node: '>=16'
459+
commands: node test/instrumentation/modules/finalhandler.test.js
452460

453461
memcached:
454462
versions: '>=2.2.0'

Diff for: package-lock.json

+79-36
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@
165165
"express": "^4.17.1",
166166
"express-queue": "^0.0.13",
167167
"fastify": "^5.0.0",
168-
"finalhandler": "^1.1.2",
168+
"finalhandler": "^2.1.0",
169169
"generic-pool": "^3.7.1",
170170
"get-port": "^5.1.1",
171171
"glob": "^7.2.3",

Diff for: test/instrumentation/modules/finalhandler.test.js

+13
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,19 @@ if (process.env.GITHUB_ACTIONS === 'true' && process.platform === 'win32') {
1414
process.exit(0);
1515
}
1616

17+
// [email protected] broke <=14 support (https://github.com/pillarjs/finalhandler/issues/87)
18+
var finalhandlerVer = require('finalhandler/package.json').version;
19+
var semver = require('semver');
20+
if (
21+
semver.gte(finalhandlerVer, '2.1.0') &&
22+
semver.lt(process.version, '16.0.0')
23+
) {
24+
console.log(
25+
`# SKIP finalhandler@${finalhandlerVer} does not support node ${process.version}`,
26+
);
27+
process.exit();
28+
}
29+
1730
var agent = require('../../..').start({
1831
serviceName: 'test',
1932
secretToken: 'test',

0 commit comments

Comments
 (0)